Skip to content

[GPU] Improve Clamp operation to handle INT64_MIN precision conversion #39535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgbihu wants to merge 2 commits into
base: master
Choose a base branch
from
+90 −0
Open

[GPU] Improve Clamp operation to handle INT64_MIN precision conversion #39535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
831236c
[GPU] Improve Clamp operation to handle INT64_MIN precision conversion
sgbihu Nov 5, 2026
dba00f4
[GPU] Add tests for Clamp operation with INT64_MIN handling
sgbihu Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions ...ugins/intel_cpu/tests/functional/shared_tests_instances/single_layer_tests/activation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
//

#include <vector>
#include <cstdint>
#include <limits>

#include "common_test_utils/test_enums.hpp"
#include "single_op_tests/activation.hpp"
Expand All @@ -18,6 +20,45 @@ const std::vector<ov::element::Type> model_types = {
ov::element::f16
};

const auto clampLowerBoundInputShapes =
ov::test::static_shapes_to_test_representation(std::vector<ov::Shape>{{1, 8}});

INSTANTIATE_TEST_SUITE_P(
smoke_Clamp_LowerBound,
ActivationLayerTest,
::testing::Values(
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int64_t>::lowest()), 5.0f}},
ov::element::i32,
{clampLowerBoundInputShapes, ov::Shape{}},
ov::test::utils::DEVICE_CPU},
ov::test::activationParams{{ActivationTypes::Clamp, {-2147483904.0f, 5.0f}},
ov::element::i32,
{clampLowerBoundInputShapes, ov::Shape{}},
ov::test::utils::DEVICE_CPU},
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int32_t>::lowest()), 5.0f}},
ov::element::i32,
{clampLowerBoundInputShapes, ov::Shape{}},
ov::test::utils::DEVICE_CPU},
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int64_t>::lowest()), 5.0f}},
ov::element::i64,
{clampLowerBoundInputShapes, ov::Shape{}},
ov::test::utils::DEVICE_CPU},
ov::test::activationParams{{ActivationTypes::Clamp, {-2147483904.0f, 5.0f}},
ov::element::i64,
{clampLowerBoundInputShapes, ov::Shape{}},
ov::test::utils::DEVICE_CPU},
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int32_t>::lowest()), 5.0f}},
ov::element::i64,
{clampLowerBoundInputShapes, ov::Shape{}},
ov::test::utils::DEVICE_CPU}),
[](const testing::TestParamInfo<ov::test::activationParams>& info) {
return "Case" + std::to_string(info.index);
});

const std::map<ActivationTypes, std::vector<std::vector<float>>> activationTypes = {
{ActivationTypes::Sigmoid, {}},
{ActivationTypes::Tan, {}},
Expand Down
6 changes: 6 additions & 0 deletions src/plugins/intel_gpu/src/plugin/ops/unary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
#include "intel_gpu/plugin/program_builder.hpp"
#include "transformations/utils/utils.hpp"

#include <cstdint>
#include <limits>

#include "openvino/op/tanh.hpp"
#include "openvino/op/elu.hpp"
#include "openvino/op/sigmoid.hpp"
Expand Down Expand Up @@ -100,6 +103,9 @@ static void CreateClampOp(ProgramBuilder& p, const std::shared_ptr<ov::op::v0::C
double min = op->get_min();
double max = op->get_max();
if (op->get_output_element_type(0) == ov::element::i32) {
// Precision conversion preserves Clamp attributes, including i64 lower bounds.
// INT32_MIN is exactly representable as float and avoids an out-of-range convert_int.
min = std::max<double>(std::numeric_limits<int32_t>::lowest(), min);
// Currently jitter saves all compile time constant as floats
// and we have a code like that: (int)(as_float(0x4f000000))
// So values in range (2147483583.0, 2147483647.0] are converted to 2147483648.0 due to fp32 representation error
Expand Down
43 changes: 43 additions & 0 deletions ...ugins/intel_gpu/tests/functional/shared_tests_instances/single_layer_tests/activation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
#include "single_op_tests/activation.hpp"
#include "common_test_utils/test_constants.hpp"

#include <cstdint>
#include <limits>

namespace {
using ov::test::ActivationLayerTest;
using ov::test::ActivationParamLayerTest;
Expand Down Expand Up @@ -130,4 +133,44 @@ INSTANTIATE_TEST_SUITE_P(smoke_Activation_Basic_Prelu, ActivationLayerTest, basi

INSTANTIATE_TEST_SUITE_P(smoke_Activation_Basic, ActivationParamLayerTest, basicPreluCases(), ActivationLayerTest::getTestCaseName);

const auto clampLowerBoundInputShapes = std::make_pair(
ov::test::static_shapes_to_test_representation(std::vector<ov::Shape>{{1, 8}}),
ov::Shape{});

INSTANTIATE_TEST_SUITE_P(
smoke_Clamp_LowerBound,
ActivationLayerTest,
::testing::Values(
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int64_t>::lowest()), 5.0f}},
ov::element::i32,
clampLowerBoundInputShapes,
ov::test::utils::DEVICE_GPU},
ov::test::activationParams{{ActivationTypes::Clamp, {-2147483904.0f, 5.0f}},
ov::element::i32,
clampLowerBoundInputShapes,
ov::test::utils::DEVICE_GPU},
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int32_t>::lowest()), 5.0f}},
ov::element::i32,
clampLowerBoundInputShapes,
ov::test::utils::DEVICE_GPU},
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int64_t>::lowest()), 5.0f}},
ov::element::i64,
clampLowerBoundInputShapes,
ov::test::utils::DEVICE_GPU},
ov::test::activationParams{{ActivationTypes::Clamp, {-2147483904.0f, 5.0f}},
ov::element::i64,
clampLowerBoundInputShapes,
ov::test::utils::DEVICE_GPU},
ov::test::activationParams{{ActivationTypes::Clamp,
{static_cast<float>(std::numeric_limits<int32_t>::lowest()), 5.0f}},
ov::element::i64,
clampLowerBoundInputShapes,
ov::test::utils::DEVICE_GPU}),
[](const testing::TestParamInfo<ov::test::activationParams>& info) {
return "Case" + std::to_string(info.index);
});

} // namespace
Loading