Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
docs/dev/ci/github_actions/adding_tests.md, explaining why known-failing builds/tests should not run automatically on the initial pre-commit attempt, even if they are non-blocking or outsideOverall_Status: they waste runner capacity, create noise, provide no per-change signal and misrepresent validation.github.run_attempt > 1, as with draft PR validation. A full re-run also launches the regular workflow, and the condition can match automated re-runs; Smart CI skip rules still apply.Overall_Statusonly after it passes reliably. Add the matching pitfall to theov-github-actions-ciskill.Tickets:
AI Assistance:
git diff --cached --check: passed. This is a documentation-only change, so no build or tests were run.