Repository navigation
Conversation
Step 6 of "Create a backup" labelled infrahub-backup restore as a way to review what would be restored. The command overwrites the target deployment. Replace it with read-only archive commands, show the restore against a staging project, and warn that restore has no dry-run mode. Fixes #206
Deploying infrahub-ops-cli with
|
| Latest commit: |
f4bf253
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b072cd2c.infrahub-ops-cli.pages.dev |
| Branch Preview URL: | https://ic-docs-backup-restore-tl-dr.infrahub-ops-cli.pages.dev |
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…ployment ID The archive stores its files under backup/, so the metadata commands in Steps 4 and 6 must read backup/backup_information.json. Restoring into staging now passes --reset-deployment-id so staging does not report the production identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206.
Problem
Step 6 of Create a backup labelled this command as a way to "Review what would be restored":
The command restores the archive over the target deployment.
restorehas no dry-run flag (onlyprunehas one), so a reader who runs it to check a backup overwrites their running Infrahub.Change
Step 6 now:
tar -tzfand thebackup_information.jsonmetadata), as Step 4 already does--project=infrahub-staging), matching the example in Restore from a backuprestorereplaces the data of the target deployment and has no dry-run modeDocs only, so labelled
ci/skip-changelog. Vale passes on the changed file.