Repository navigation
Manual merge develop into infrahub-develop - #1529
Conversation
…teKind into the enum table (#1523) The schema tests added by #1135 checked validator errors with `any("<field>" in message ...)`. That passes as long as some message mentions the field, so a changed message text or an extra error does not fail the suite. Each of those tests now asserts exactly one error with its full message, or its field, reason and received value. The separate AttributeKind test checked only that "Text" is present and "String" is absent. AttributeKind is now an entry of the parametrized enum table, which also pins the member order. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Merge stable into develop
#1490) * chore(lint): exclude the vendored spec-kit scripts from ruff and ty The agent-context extension that Spec Kit 1.2 ships contains Python that does not follow the project's rules. `.specify` is in the ruff and ty exclude lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(speckit): upgrade Spec Kit to 1.2.5 and opsmill-speckit to 1.4.1 Follows the "Upgrading spec-kit to 1.2 or later" steps of opsmill-speckit v1.4.1, as in opsmill/infrahub#11376: - remove the review extension, which does not install on Spec Kit 1.x - upgrade the Claude integration to Spec Kit 1.2.5 - reinstall opsmill from the v1.4.1 tag - add the checkpoint extension and the critique-opsmill preset - replace the infrahub Jira preset with jira-branch, and delete dev/spec-kit/presets/infrahub - update agent-context to 1.0.2, the version Spec Kit 1.2.5 ships, and keep its CLAUDE.md configuration No file that the integration manages had local changes, so the forced upgrade loses nothing. Also deletes the command files that Spec Kit 0.x generated in .agents/commands. Spec Kit 1.2 uses the skills in .agents/skills instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(speckit): replace the infrahub branch hook with the git extension's The infrahub extension, added in #979, ran speckit.infrahub.feature before each specification to check the Jira reference in the branch name. Its command file was removed with the infrahub preset, so the hook pointed to a command that no longer exists. The jira-branch preset now does that check in speckit.git.feature, so the hook is the git extension's, as in opsmill/infrahub#11376. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(lint): exclude the spec-kit presets from rumdl The upgrade installs presets in .specify/presets, which rumdl checked, unlike .specify/extensions and .specify/templates. Spec Kit regenerates these files on each upgrade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(speckit): run the spec-kit scripts with the project's Python The plan, tasks and template scripts of Spec Kit 1.2 need PyYAML, which the system python3 often lacks. The Claude Code and Codex hooks that opsmill-speckit 1.4.1 ships point them at the project environment when it has PyYAML, and do nothing otherwise. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X9ZEsTmHy1shuNRt88HiUb --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Merge stable into develop
…-infrahub-develop-20261116
…ertions develop (#1523) switched OutOfEnumCase to expected_input/expected_reason and asserted exact messages; infrahub-develop (e5d1ed6) added a dropdown-choice-state case with the old invalid_value field and made the choices fixture a Dropdown attribute. Port the new case to the new fields and expect Dropdown in the choice color message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying infrahub-sdk-python with
|
| Latest commit: |
d10cef2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://503cfc57.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://merge-develop-into-infrahub-p401.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #1529 +/- ##
=================================================
Coverage 87.88% 87.88%
=================================================
Files 157 157
Lines 15658 15658
Branches 2114 2114
=================================================
Hits 13761 13761
Misses 1336 1336
Partials 561 561
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This PR has 10,953 reviewable changed lines after ignored/generated files are excluded, above this repository's 10,000-changed-line automatic review limit. The raw diff is 11,041 lines before ignored/generated files are excluded. Most of the diff comes from:
Comment |
Supersedes #1525, which fails the
python-lintcheck after merging.Summary
Merges
developintoinfrahub-develop.Conflicts resolved
Git merged the branches without text conflicts. The merged code still failed the type check and one unit test, because the two branches changed
tests/unit/test_schema_offline_validation.pyin incompatible ways:develop(test(schema): pin offline-validation errors and AttributeKind values #1523) renamed theOutOfEnumCasefieldinvalid_valuetoexpected_inputandexpected_reason, and made the tests compare exact error messages.infrahub-develop(e5d1ed6) added adropdown-choice-statecase that still usedinvalid_value. It also changed the_schema_with_choicesfixture so that it builds aDropdownattribute instead of aTextattribute.The fix in d10cef2:
dropdown-choice-statecase toexpected_input="removed"andexpected_reason="Input should be 'present' or 'absent'". The error reason is the one the validator returns.test_choice_bad_color_is_rejectedexpects from...attributes[0].Text.choices[0].color...to...attributes[0].Dropdown.choices[0].color..., to match the new fixture.Validation
uv run invoke format lint-codepasses.uv run invoke docs-validatepasses.tests/unit/pytest_plugin/test_plugin.pywere not run, because the testcontainers plugin crashes on this machine (invalid CPU frequency data). CI runs them.🤖 Generated with Claude Code