Skip to content

Preserve syscheck report_changes newlines under control-char strip. - #2361

Merged
atomicturtle merged 2 commits into
ossec:mainfrom
atomicturtle:fix/2359-report-changes-ctrl-strip
Oct 18, 2026
Merged

atomicturtle merged 2 commits into
ossec:mainfrom
atomicturtle:fix/2359-report-changes-ctrl-strip

Conversation

@atomicturtle

Copy link
Copy Markdown
Member

CVE-2020-8445 stripping removed the '\n' that frames report_changes diffs, so DecodeSyscheck glued path and diff and raised rule 554. Keep newlines (and tabs) for syscheck locations only.

Closes issue #2359

CVE-2020-8445 stripping removed the '\n' that frames report_changes
diffs, so DecodeSyscheck glued path and diff and raised rule 554.
Keep newlines (and tabs) for syscheck locations only.

Closes issue ossec#2360

Signed-off-by: Scott R. Shinn <scott@atomicorp.com>
@atomicturtle
atomicturtle requested a balanced review from Copilot October 15, 2026 17:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Signed-off-by: Scott R. Shinn <scott@atomicorp.com>
@atomicturtle
atomicturtle merged commit 72e8ffd into ossec:main Oct 18, 2026
5 checks passed
atomicturtle added a commit that referenced this pull request Oct 18, 2026
Backport the #2361 fix onto v4.4.0: OS_CleanMSG keeps '\\n'/'\\t' for
syscheck locations (OS_IsSyscheckLocation) so report_changes framing
survives DecodeSyscheck (#2359), while non-syscheck messages still strip
C0/DEL for CVE-2020-8445. Include report_changes_ctrl_test.c so shared
unit tests cover the location gate and preserve/strip cases.
atomicturtle added a commit that referenced this pull request Oct 18, 2026
Maintenance release on the v4.4.0 branch for the #2359/#2361 control-char
strip fix. Update VERSION, defs, packaging metadata, llms.txt, and
CHANGELOG; keep the maintenance branch name as v4.4.0.
atomicturtle added a commit that referenced this pull request Oct 18, 2026
Backport #2361 report_changes control-char strip fix (4.4.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants