Repository navigation
fix Windows execd: neutralize cmd.exe metacharacters in AR args - #2367
Merged
atomicturtle merged 1 commit intoOct 20, 2026
Merged
atomicturtle merged 1 commit into
atomicturtle merged 1 commit into
Conversation
WinExecdRun builds a quoted CreateProcess command line for .cmd active responses. An enrolled agent can put a double quote in the event location; cmd.exe then treats following "&…&" as a separate command and runs it as LocalSystem on other Windows agents with AR enabled. Sanitize user, IP, and the request remainder (including location) with OS_WinExecdCleanArg before both the add and timeout-delete lines are built: replace '"', '%', and control characters with '_'. Add issue_win_execd_cmd_injection regression. Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-RYKB1OLI. Signed-off-by: Scott R. Shinn <scott@atomicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WinExecdRun builds a quoted CreateProcess command line for .cmd active responses. An enrolled agent can put a double quote in the event location; cmd.exe then treats following "&…&" as a separate command and runs it as LocalSystem on other Windows agents with AR enabled.
Sanitize user, IP, and the request remainder (including location) with OS_WinExecdCleanArg before both the add and timeout-delete lines are built: replace '"', '%', and control characters with '_'. Add issue_win_execd_cmd_injection regression.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-RYKB1OLI.