Skip to content

add audit ci workflow - #1054

Open
valoq wants to merge 1 commit into
ouch-org:mainfrom
valoq:audit
Open

add audit ci workflow#1054
valoq wants to merge 1 commit into
ouch-org:mainfrom
valoq:audit

Conversation

@valoq

@valoq valoq commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

This workflow runs cargo audit weekly and on dependency changes and opens a PR for any findings.

This may create more bot PRs though.

The alternative is to just run the audit without PRs and run cargo update manually before releases, which is more error prone

@marcospb19

marcospb19 commented Aug 27, 2026

Copy link
Copy Markdown
Member

if the bot opens a PR, that catches our attention, that's important at least

so would it be reasonable for me to close it, bump that dependency myself and make a PR for it?

@marcospb19

marcospb19 commented Aug 27, 2026

Copy link
Copy Markdown
Member

maybe it would be better to run cargo update dep instead of the more general cargo update 🤔

if that's the case I think I'm fine with the bot PRs : )

wdyt

@valoq

valoq commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator Author

What most rust projects do is just to run the audit command in ci and have the ci report failures if something comes up.
We could do that too but it would add more work.

Im not sure whats the best option here

@marcospb19

marcospb19 commented Sep 2, 2026

Copy link
Copy Markdown
Member

If that's harder, I'd keep this approach.

About my previous suggestion, maybe we could do:

cargo audit --json | jq -r '.vulnerabilities.list[].package.name' | tr '\n' ' '

To get the list of packages that were found and then we pass that down from one step to the other, and invoke cargo update $(pkgs) instead of the wider cargo update.

EDIT: using the $GITHUB_OUTPUT feature.

@valoq

valoq commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

Its not harder, its more manual work, but I suspect it will rarely fire.
I will open another PR to just add the ci check for now and we run cargo update or cargo update dep manually when it fires.
dependabot should already catch most.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants