Repository navigation
Fix llama.cpp ROCm image build: run under bash (pipefail) - #13
Merged
Merged
Conversation
… guards work The first candidate build failed at the apt step: the RUN used set -euxo pipefail but the SHELL bash directive came after it, so it ran under the base image's /bin/sh (dash), which rejects -o pipefail. Move SHELL to before the first RUN so every build step (including the AVX-512 objdump guard) runs under bash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first candidate build of
llama-cpp-rocm-gfx1201-avx2failed at the apt step:The apt
RUNusedset -euxo pipefail, but theSHELL ["/bin/bash","-c"]directive was declared after it, so it ran under the base image's/bin/sh(dash), which rejects-o pipefail. This movesSHELLabove the firstRUNso every build step — including the AVX-512objdumpguard, which also uses[[ ]]— runs under bash.Dockerfile-only fix; no pin or recipe change. Re-dispatch the candidate build after merge.