Repository navigation
Port to league/commonmark 2 - #5
Merged
Merged
Conversation
CliRenderer now implements ChildNodeRendererInterface, the Cli*RendererInterface interfaces extend NodeRendererInterface and CliExtension is a ConfigurableExtensionInterface (registers the 'renderer' config schema). Rendered output is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the renderer from league/commonmark 1.x (10 security advisories, blocks installs on current Composer) to commonmark ^2.8. Intended release: 4.0.0.
Rendered output is unchanged.
test/res/e2e/1.expectedis untouched and still passes.Breaking changes
^8.1(was>=7.1),league/commonmark ^2.8,php-school/keylighter ^0.8.5CliBlockRendererInterface/CliInlineRendererInterfacenow extend commonmark'sNodeRendererInterface.render()is(Node $node, ChildNodeRendererInterface $childRenderer): string, and the$inTightListparam is gone.CliRendererimplementsChildNodeRendererInterfaceand takes a commonmark 2EnvironmentInterface.renderBlock()/renderInline()takeNode.CliExtensionis aConfigurableExtensionInterfacewith arendererconfig schema (renderer.widthmust be an int, default 30)Environment+MarkdownParserinstead ofDocParserOther
--stop-on-error, superseded runs cancelled. The dead codecov step is removed.Verified locally: PHP 8.5 (40 tests OK, phpcs and PHPStan clean) and PHP 8.1 with 8.1-resolved deps (40 tests OK, phpcs and PHPStan clean).
Only dependent is php-school/php-workshop. It will be ported to this API on its
docker-fixesbranch.🤖 Generated with Claude Code