Repository navigation
Update PHP8 appreciate for new workshop version - #49
Open
AydinHassan wants to merge 28 commits into
Open
AydinHassan wants to merge 28 commits into
AydinHassan wants to merge 28 commits into
Conversation
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
May 11, 2024 08:47
dcce570 to
d200dbb
Compare
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
May 17, 2024 19:16
f9a85f6 to
f435075
Compare
Member
Author
|
@mikeymike only a few failures 😱 the fix for the big issue with bind mounts was this: https://github.com/php-school/php-workshop/pull/300/files#diff-b8aa8129dc6b9ec2a602a608dfce32dfecafdfb0e1579d49cfb79076ffbc8521L60 - no idea why, I just randomly commented it out and it started working. Locally I have 2 failures and it seems like a timing issue because when I run the failing ones on it's own it works fine. But we pretty close now! |
Member
Author
|
The two failures on |
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
May 25, 2024 12:03
8f47449 to
397bcbe
Compare
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
May 25, 2024 13:47
ad3b81f to
1dc4d4a
Compare
AydinHassan
force-pushed
the
workshop-rewrite
branch
from
May 25, 2024 14:01
75ef338 to
8bcd69b
Compare
composer.lock needs regenerating once php-workshop docker-fixes is pushed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lication) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ny/console 7 HaveTheLastSay now permits an extra named escape argument. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rage upload Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… on the 8.3 runtime image Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011CqRqxTfcNvVkKoy8e4aG9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011CqRqxTfcNvVkKoy8e4aG9
Runs on PRs to any branch and builds the runtime image before the docker tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011CqRqxTfcNvVkKoy8e4aG9
Upgrade to PHP 8.2+, PHPUnit 11 and PHPStan 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.