Repository navigation
Fix auto-deploy: SSH repo alias, pin master, trigger on master - #290
Merged
Merged
Conversation
- deploy.php repository -> git@github-phpschool (per-repo deploy key on imp, avoids the shared IdentitiesOnly github.com key collision) - Pin branch=master so Deployer checks out master (CI runner is detached HEAD, which would otherwise fall back to the stale default `online` branch) - deploy.yml now fires on push to master (was `online`, which has no deploy workflow so the deploy never ran) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P66wwaJwSSyXxza8ymKito
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the Capistrano -> PHP Deployer migration so pushes to master auto-deploy phpschool.io.
Changes
repository->git@github-phpschool:...— imp's deploy user now has a per-repo read-only deploy key (phpschool_deploy) +Host github-phpschoolSSH alias, avoiding the box-wideIdentitiesOnlygithub.com key that was bound to another repo.set('branch', 'master')— the CI runner checks out a detached HEAD, so Deployer would otherwise fall back to the repo default branchonline(670 commits stale). Pinning guarantees master is deployed.online->master(+ concurrency group) — the workflow only exists on master andonlinehas no deploy workflow, so the deploy never fired.Server prep (done on imp)
/var/www/phpschool.iomanual deploy converted to Deployer layout:current -> releases/1,.dep/latest_release=1, shared symlinks repointed. releases/1 verified serving 200 as a rollback.🤖 Generated with Claude Code
https://claude.ai/code/session_01P66wwaJwSSyXxza8ymKito