Repository navigation
Run exercises that expose ports on a network without internet access - #355
Merged
Merged
Conversation
AydinHassan
force-pushed
the
hardening
branch
from
October 24, 2026 18:27
9f8540b to
b7e471f
Compare
AydinHassan
force-pushed
the
sandbox-network
branch
from
October 24, 2026 18:27
e359967 to
8df3641
Compare
AydinHassan
force-pushed
the
sandbox-network
branch
from
October 24, 2026 20:19
8df3641 to
bcdac78
Compare
Also pulls in the php-workshop fix for running exercises.
AydinHassan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy.phpcreates thephp-school-sandboxDocker network if it doesn't exist yet. It has no internet access.CloudInstalledWorkshoppasses that network to php-workshop, so exercises that expose ports, like Time Server, run on it.Tested locally with the Docker sandbox: run and verify pass for 22 of 24 exercises, Time Server included. The other two are composer exercises, which my test script can't install.