Repository navigation
Stop logging 404s and rotate the app log - #358
Merged
Merged
Conversation
Bots probing for URLs logged about 125,000 404s with full stack traces, and the log was a single file with no rotation, now 280MB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
var/logs/app.logon imp is 280MB. About 125,000 of its entries are 404s from bots probing URLs, each logged at ERROR level with a full stack trace.ErrorHandlersubclass skips logging 4xxHttpExceptions (404, 405 and the like). Responses don't change: they still return the JSON{"error": "..."}body.app-YYYY-MM-DD.log) and keeps 14 days.Tested locally:
/api/wp-adminandDELETE /api/postsreturn 404 and 405 JSON and nothing is logged. Added tests that a 404 isn't logged and a 500 is.After deploy, the old
app.logcan be deleted.