Repository navigation
Give the problem dialog a fixed height - #361
Merged
Merged
Conversation
AydinHassan
changed the title
AydinHassan
changed the title
AydinHassan
force-pushed
the
problem-modal-after-load
branch
from
October 25, 2026 06:47
1d3ac80 to
35090be
Compare
AydinHassan
changed the title
It opened small with a spinner, then grew from the middle of the screen when the problem text arrived, which looked like it slid up. Now it opens at its full height and the text fills in.
AydinHassan
force-pushed
the
problem-modal-after-load
branch
from
October 25, 2026 06:50
35090be to
f0ea8df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entering the editor, the problem dialog opened small, with a spinner, in the middle of the screen. When the problem text arrived it grew to its full height, so its top shot up the screen (a layout shift of 0.12).
Now it has a fixed height, 5/6 of the screen, from the start. The spinner shows while the problem loads, then the text fills in and scrolls inside if it's long. Tested against a local copy of the site, logged in: the dialog no longer moves.