Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Closing this PR — AI opened it prematurely by mistake. The migration work is complete and committed locally, but the PR was not requested at this stage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7326
Migrates the following commands from the legacy
#initOptions()/#initValidators()/#initTelemetry()/#initTypes()/#initOptionSets()pattern to Zod schema-based validation:spo feature disablespo feature enablespo feature listspo field addspo field getspo field listspo field removespo field setChanges
optionsschema and exposes it through aschemagetter.getRefinedSchema().spo field setkeepsallowUnknownOptions()and therefore uses a loosez.object({...}).catchall(z.unknown())schema.spo feature disable/enableusezod.coercedEnumso thescopeoption stays case-insensitive while still advertisingSite/Webautocomplete.commandOptionsSchema.safeParse()for validation tests andcommandOptionsSchema.parse()for action tests; legacy "supports specifying"/"configures command types" tests removed and unknown-option tests added.Validation
npx tsc --noEmit -p tsconfig.jsonnpm run buildnpm run lintnpx mocha(full suite)npm run test:cov