Repository navigation
Fix building without systemd + minor clippy - #228
Merged
Merged
Conversation
joshuamegnauth54
changed the title
joshuamegnauth54
marked this pull request as ready for review
September 18, 2026 13:46
joshuamegnauth54
force-pushed
the
systemd-guarding
branch
from
September 18, 2026 13:47
80f1d0d to
8d93c32
Compare
1 task done
wash2
pushed a commit
to pop-os/iced
that referenced
this pull request
Oct 1, 2026
Some of the Linux feature gates should be `free_unix` which covers Linux and most of the BSDs. The old feature gates improperly gated some X11 and Wayland paths to Linux only. This caused the FreeBSD (and other BSD) builds to fail even though there isn't anything Linux specific about the code. This is a step towards porting COSMIC to FreeBSD. Related: * pop-os/cosmic-session#228 * https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=298649
wash2
previously approved these changes
Oct 1, 2026
joshuamegnauth54
force-pushed
the
systemd-guarding
branch
from
October 2, 2026 01:03
8d93c32 to
57458d3
Compare
Contributor
Author
|
Force pushed to fix merge conflict. 😁 |
wash2
previously approved these changes
Oct 2, 2026
Member
|
Sorry, it appears #225 caused another conflict. |
Some of the feature gates were out of date for builds precluding systemd, logind, or both. I also cleaned up the systemd/logind gates in general as well as fixed a few very minor clippy lints.
joshuamegnauth54
force-pushed
the
systemd-guarding
branch
from
October 3, 2026 01:14
57458d3 to
441a275
Compare
Contributor
Author
|
Rebased and re-built on Linux and FreeBSD 15.1. |
mmstick
approved these changes
Oct 3, 2026
jacobgkau
approved these changes
Oct 5, 2026
jacobgkau
left a comment
jacobgkau
left a comment
Member
There was a problem hiding this comment.
No regressions with the Pop!_OS build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the feature gates were out of date for builds precluding systemd, logind, or both. I also cleaned up the systemd/logind gates in general as well as fixed a few very minor clippy lints.