Skip to content

fix: hear the session's requests while waiting for the compositor - #240

Open
LinuxBoy-96 wants to merge 1 commit into
pop-os:masterfrom
LinuxBoy-96:C13
Open

LinuxBoy-96 wants to merge 1 commit into
pop-os:masterfrom
LinuxBoy-96:C13

Conversation

@LinuxBoy-96

@LinuxBoy-96 LinuxBoy-96 commented Nov 8, 2026 •

Copy link
Copy Markdown
  • Problem: start() waits for cosmic-comp's environment (env_rx.await) without listening for restart requests at the same time. The channel stays open forever: the task that reads the compositor's socket will never see its end, because cosmic-session itself keeps the other end of the socket (comp, kept alive in the spawned task).
  • When: cosmic-comp exits before sending its environment: GPU init failure, panic at startup, startup with no output, or restart after a crash.
  • Consequence: the session stays frozen on a black screen or a console, never restarts and never gives control back to the login manager.

Related: pop-os/cosmic-comp#3044 aborts a stuck cosmic-comp; this makes sure the session comes back even if the new one can't start.


  • I have not included any LLM (also known as AI) generated content in this PR, including code, comments, and descriptions.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.
  • I have read and followed all of the above requirements. For more information, see our contributor guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant