Repository navigation
HOL-Light: Minor clean-ups - #1502
Merged
Merged
Conversation
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (433 configurations)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (433 configurations)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (433 configurations)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (433 configurations)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (433 configurations)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (433 configurations)
|
mkannwischer
force-pushed
the
hol-speedup-followup
branch
from
November 2, 2026 09:21
ca1a498 to
39c8f32
Compare
mkannwischer
marked this pull request as ready for review
November 2, 2026 09:22
hanno-becker
reviewed
Nov 3, 2026
hanno-becker
requested changes
Nov 3, 2026
hanno-becker
left a comment
Contributor
There was a problem hiding this comment.
I think the 2nd commit is a step back; see comment. Happy with the first.
aarch64_utils.ml redefined SIMD_SIMPLIFY_CONV and SIMD_SIMPLIFY_TAC, shadowing the shared definitions in common/mldsa_specs.ml that it already loads. The conversion is identical and the shared tactic only additionally matches x86 int256 registers, which never occur in Arm goals, so use the shared definitions. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
mkannwischer
force-pushed
the
hol-speedup-followup
branch
from
November 4, 2026 03:57
39c8f32 to
889c47a
Compare
hanno-becker
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.