Repository navigation
scripts/tests: Align GitHub summary rows by benchmark name - #1536
Draft
mkannwischer wants to merge 1 commit into
Draft
mkannwischer wants to merge 1 commit into
mkannwischer wants to merge 1 commit into
Conversation
The GitHub job summary combined the outputs of the three parameter sets line by line using zip(). This truncated the table to the shortest output and misaligned rows whenever the parameter sets print different benchmarks. Match lines of the form `name = value` by name instead, and keep all lines. Ports pq-code-package/mlkem-native#1980. Resolves #1535. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub job summary combined the outputs of the three parameter sets line by line using zip(). This truncated the table to the shortest output and misaligned rows whenever the parameter sets print different benchmarks.
Match lines of the form
name = valueby name instead, and keep all lines.