Skip to content

tests: neutral fixtures - #38

Merged
pretyflaco merged 2 commits into
mainfrom
test/neutral-fixtures
Nov 5, 2026
Merged

pretyflaco merged 2 commits into
mainfrom
test/neutral-fixtures

Conversation

@pretyflaco

Copy link
Copy Markdown
Owner

What

Tests now use made-up names in place of real ones:

  • team slugs: team-a / team-b;
  • people and speaker names: made-up names instead of real participants;
  • session ids: synthetic ones. The two that matched production ids were found against a list of real job ids and replaced.

Each name is replaced consistently within its test. A few local variables needed hand-fixing after the rename (team-a = … → team_a = …).

Scope: tests only; there is no behavior change.

Checks

  • 801 passed (excluding test_gui.py).
  • ruff check millet/ tests/ passes.
  • Leak grep over the added lines found nothing.

Made-up team slugs (team-a, team-b), names and synthetic session ids instead
of real ones.  No behavior change.
@pretyflaco
pretyflaco force-pushed the test/neutral-fixtures branch from 3070a9f to ea57492 Compare November 5, 2026 10:09
Real session ids (full and prefixes) in a comment, a doc and a test, and
production incident dates in comments.  Dates of external API verifications
are kept.
@pretyflaco

Copy link
Copy Markdown
Owner Author

Added a second commit, chore: drop remaining real session ids and incident dates:

  • Session ids: real session ids that the earlier sweep (chore: no deployment- or organization-specific references #37) missed because its id pattern had the wrong length. One is in a summarize.py comment, a prefix is in docs/tee-summarization-evaluation.md, and one is in a test_label.py comment.
  • Incident dates: production incident dates in label.py, speaker_repair.py and summarize.py. Dates of external API verifications are kept.

Checks: 801 tests passed and ruff is clean.

@pretyflaco
pretyflaco merged commit 0ee9d60 into main Nov 5, 2026
3 checks passed
@pretyflaco
pretyflaco deleted the test/neutral-fixtures branch November 5, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant