Repository navigation
Conversation
The cluster rules aggregate by namespace and service, removing job from several firing alerts. Set the cluster-name template to those retained labels so descriptions identify the cluster consistently. Add a Jsonnet regression covering all seven cluster descriptions and custom naming without changing expressions or other alert fields. Signed-off-by: Mikhail Basov <michael.s.basov@gmail.com>
Regenerate the Alertmanager PrometheusRule with the namespace/service cluster-name template. Only the seven cluster descriptions change; expressions and other alert fields stay the same. Signed-off-by: Mikhail Basov <michael.s.basov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Alertmanager mixin groups cluster alerts by
namespace,service, but inherits a cluster-name annotation that readsjob. Aggregation removesjob, so several firing alerts describe an unnamed cluster. The same problem was reported in the closed downstream helm-charts issue #4872.Set
alertmanagerClusterNameto the retained namespace and service and regenerate the seven cluster descriptions. Member and peer alerts use the same cluster identifier. The upstream Alertmanager mixin's default configuration is unchanged, and custom cluster-name overrides still work.Alertmanager instances within the cluster have different configurations.Alertmanager instances within the monitoring/alertmanager-main cluster have different configurations.All alert expressions, firing durations, labels, summaries, runbook links, and resource metadata are unchanged.
make generate,make test, andmake lintpass. The new Jsonnet regression runs throughmake test, checks all seven descriptions and custom naming, and fails on the old source. Promtool 3.15.0 also passes seven complete-rule fixtures against the applied source, with firing, pending, and healthy controls;promtool check rulesvalidates all nine generated rules. The notification fixtures configurepagerdutyas critical to exercise both severity variants.This was reproduced while studying alert rules across projects; study results are published only in aggregate. AI assistance was used for source analysis, implementation, and regression tests.
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry