feat(ui): add dynamic provider schema boundary - #12646
Open
Alan-TheGentleman wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is PR 12 in the Registry UI chain and follows #12590.
The backend now exposes provider credential schemas through
GET /api/v1/provider-schemas/{type}. The UI needs a narrow, defensive transport boundary before it can interpret or render dynamic provider onboarding forms.Description
/api/v1/provider-schemas/{type}secret_typesmapThis PR intentionally does not interpret JSON Schema or render onboarding forms. That work belongs to the next focused child.
Chain
Steps to review
ui/types/provider-schema.tsfor the transport contracts.ui/actions/providers/provider-schemas.adapter.tsfor URL construction, authentication, and cache behavior.ui/actions/providers/provider-schemas.tsfor fail-closed response validation and safe error mapping.Validation
pnpm exec vitest run --project unit actions/providers/provider-schemas.adapter.test.ts actions/providers/provider-schemas.test.ts— 16/16 passedpnpm run test:unit— 442 files, 3,169 tests passedpnpm run typecheck— passedgit diff --check 67aab39847— cleanreview-49e8c3c41f84f0cd)Checklist