Repository navigation
Add strict completed pnpm dependency cache modes - #13
Merged
Merged
Conversation
Harold Hunt (huntharo)
marked this pull request as ready for review
October 4, 2026 21:37
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p-map-iterable needs one producer to populate a completed pnpm dependency tree and consumers to restore it without installing dependencies or running lifecycle scripts. v1.5.0 caches the pnpm download store and intentionally installs on ordinary cache hits. Native pnpm 12 also ignores the existing
npm_config_store_dirspelling during store discovery.This adds opt-in
dependency-cache: node-moduleswith explicitcache-mode: populateandcache-mode: restore. A warm producer probes only; a cold producer performs a frozen install, verifies unchanged lock bytes and installation inputs, writes Node major/ABI metadata, and saves inline. A post-save exact probe prevents cache-service warnings from allowing a producer to succeed without an entry. Strict consumers fail on exact misses or incompatible metadata and never install, repair, or save dependencies.The new
cache-keyoutput uses the same deterministic key for producers and consumers. Completed trees have a distinct format namespace; compatibility includes Node major, exact pnpm pin, OS/architecture, stable ImageOS, normalized directory, full installation-input hashes, action source revision, and caller policy. ImageVersion and operational role are excluded.cache-inputsaccepts additional installation files. Both pnpm store environment spellings are exported and actual discovery is checked against the selected workspace store. Subdirectory keys include inherited repository policy, and cold populations discard materialized trees before installing. The default pnpm store contract remains intact; completed mode currently requires an exact pnpm pin.actionlintpassed.pnpm-store/v11; allowed esbuild lifecycle completedThe new pnpm 12 fixture uses portable import settings and permitted esbuild tooling; pnpm 10.33.0 and its default-store regression remain covered. README documents the supported contract and producer/consumer API, including the caller requirement to disable pnpm verification before later consumer scripts.
This PR changes only configure-nodejs. p-map-iterable's direct-call migration and combined CI remain separate acceptance work. The intended release is v1.6.0 after this change is reviewed and validated.
Validated immutable commit:
e829954c87c2c195ee071a8edeaf270efeffcc0e. GitHub CI run 37236616750 passed all 31 jobs, including 108 unit/action-script tests on each supported runner OS. Compatible consumers may pin this tested SHA after upstream review; this run does not validate p-map-iterable’s pending direct-call workflows.