Fix eager import of cftime in _maybe_cast_to_cftimeindex - #11558
Open
peterhron wants to merge 4 commits into
Open
Fix eager import of cftime in _maybe_cast_to_cftimeindex#11558peterhron wants to merge 4 commits into
peterhron wants to merge 4 commits into
Conversation
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Contributor
|
Could you add a test to make sure we dont regress again? |
dcherian
approved these changes
Sep 3, 2026
Author
I have added a simple test in test_indexes. Please have a glance, if you will. Thanks. |
Author
|
@dcherian thanks for the quick approve, i just added a test and rebased today. Should be good to go, otherwise :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
whats-new.rstapi.rstAI Disclosure
Fixes a regression with eagerly-importing cftime, leading to performance degradation.