[aburrell]

Description

Addresses PyHC PHEP 3 needs, as well as updates to GitHub Actions and other dependency deprectations.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• This change requires a documentation update

How Has This Been Tested?

Unit tests

Test Configuration

• Operating system: OS X Tahoe
• Version number: Python 3.10
• Any details about your local setup that are relevant

Checklist:

• Make sure you are merging into the develop (not main) branch
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

[aburrell]

Requires an update to pysat for 3.11+ tests to pass.

[rstoneback]

Hmmm.... code tests aren't being run for some reason. There were a whole bunch of tests here.

[rstoneback]

Made some progress. Tests are running again. The filename issue has been fixed. There is a data access issue that popped up and may be related to actual changes in pysat's data access stuff as part of the latest release.

[rstoneback]

So the problem was a change in pandas 3.0. Anyway, I have a potential fix for the remaining error. I'm not exactly certain what the test really wants. However, pandas no longer likes:

        assert len(kp_inst['Kp'][kp_inst['Kp']]
                   == self.combine['fill_val']) > 0

And forcing that to a integer lookup and the test passes.

        assert len(kp_inst['Kp'].iloc[kp_inst['Kp']]
                   == self.combine['fill_val']) > 0

The issue is, so we are accessing data, and doing a comparison, but everything is wrapped in a length check. So the data check isn't very specific.

Looking at the outputs from the check, inside the length check, we get:

2019-03-20 21:00:00    False
2019-03-20 21:00:00    False
2019-03-20 21:00:00    False
2019-03-20 21:00:00    False
2019-03-20 21:00:00    False
                       ...  
2019-02-16 06:00:00     True
2019-02-16 06:00:00     True
2019-02-16 09:00:00     True
2019-02-16 06:00:00     True
2019-02-16 06:00:00     True
Name: Kp, Length: 264, dtype: bool

There isn't a single specific value that should result. This output comes from running the tests on pandas < 3.0 . I get the same output when running pandas >= 3.0. Best I can tell so far, the addition of .iloc is a valid change.