Repository navigation
Shikra: Fix QCE configuration for runtime PM - #1247
Salendarsingh Gaud (sgaud-quic) merged 5 commits into
Conversation
|
Merge Check Failed: CR Not Eligible for Merge CR 4671922 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
e8df8bb to
3e19832
Compare
|
Merge Check Failed: CR Not Eligible for Merge CR 4671922 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
3e19832 to
f575ca8
Compare
|
Merge Check Failed: CR Not Eligible for Merge CR 4671922 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
f575ca8 to
9b567da
Compare
|
Merge Check Failed: CR Not Eligible for Merge CR 4671922 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
Test Matrix
|
Test Matrix
|
Test Matrix
|
Test Matrix
|
9b567da to
6baf3bb
Compare
Test Matrix
|
6baf3bb to
46cd21e
Compare
Test Matrix
|
PR #1247 — validate-patchPR: #1247
Final Summary
|
PR #1247 — checker-log-analyzerPR: #1247
Detailed report: Full report
|
Test Matrix
|
Test Matrix
|
…nnect bandwidth scaling support\"
The Qualcomm Crypto Engine (QCE) driver currently lacks support for
runtime power management (PM) and interconnect bandwidth control.
As a result, the hardware remains fully powered and clocks stay
enabled even when the device is idle. Additionally, static
interconnect bandwidth votes are held indefinitely, preventing the
system from reclaiming unused bandwidth.
Address this by enabling runtime PM and dynamic interconnect
bandwidth scaling to allow the system to suspend the device when idle
and scale interconnect usage based on actual demand. Improve overall
system efficiency by reducing power usage and optimizing interconnect
resource allocation.
Make the following changes as part of this integration:
- Add support for pm_runtime APIs to manage device power state
transitions.
- Implement runtime_suspend() and runtime_resume() callbacks to gate
clocks and vote for interconnect bandwidth only when needed.
- Replace devm_clk_get_optional_enabled() with devm_pm_clk_create() +
pm_clk_add() and let the PM core manage device clocks during runtime
PM and system sleep.
- Register dev_pm_ops with the platform driver to hook into the PM
framework.
Tested:
- Verify that ICC votes drop to zero after probe and upon request
completion.
- Confirm that runtime PM usage count increments during active
requests and decrements afterward.
- Observe that the device correctly enters the suspended state when
idle.
This reverts commit 690704e.
Moving changes from V5 to V9
Link: https://lore.kernel.org/all/20251120062443.2016084-1-quic_utiwari@quicinc.com/
Signed-off-by: Udit Tiwari <quic_utiwari@quicinc.com>
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Signed-off-by: Roopak Houji <rhouji@qti.qualcomm.com>
…dwidth scaling support The Qualcomm Crypto Engine (QCE) driver currently lacks support for runtime power management (PM) and interconnect bandwidth control. As a result, the hardware remains fully powered and clocks stay enabled even when the device is idle. Additionally, static interconnect bandwidth votes are held indefinitely, preventing the system from reclaiming unused bandwidth. Address this by enabling runtime PM and dynamic interconnect bandwidth scaling to allow the system to suspend the device when idle and scale interconnect usage based on actual demand. Improve overall system efficiency by reducing power usage and optimizing interconnect resource allocation. Link: https://lore.kernel.org/linux-arm-msm/20260729110455.641256-1-kuldeep.singh@oss.qualcomm.com/ Signed-off-by: Udit Tiwari <udit.tiwari@oss.qualcomm.com> Tested-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Tested-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Signed-off-by: Roopak Houji <rhouji@qti.qualcomm.com>
…de configuration\"
Shikra is derived from Agatti and uses the same QCE integration.
Update the QCE node to match the underlying hardware implementation by
adjusting the fallback compatible and related properties, including
clocks and clock-names.
This reverts commit 61a279f.
moving to latest changes
Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Link: https://lore.kernel.org/linux-arm-msm/20260907-b4-shikra_crypto_changse-v6-2-0676f61894b3@oss.qualcomm.com/
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Signed-off-by: Roopak Houji <rhouji@qti.qualcomm.com>
Shikra is derived from Agatti and uses the same QCE integration. Update the QCE node to match the underlying hardware implementation by adjusting the fallback compatible and related properties, including clocks and clock-names. Since cryptobam is marked qcom,controlled-remotely, its clocks are managed remotely and hence don't specify explicitly. Link: https://lore.kernel.org/lkml/20261006-shikra_qce_fix-v1-2-8ac54d81edb4@oss.qualcomm.com/ Fixes: 3cc1e2a ("FROMLIST: arm64: dts: qcom: shikra: Add ICE, TRNG and QCE nodes") Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com> #on shikra device Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Signed-off-by: Roopak Houji <rhouji@qti.qualcomm.com>
f0789c7 to
e33dbf7
Compare
Test Matrix
|
PR #1247 — validate-patchPR: #1247
Final Summary
|
PR #1247 — checker-log-analyzerPR: #1247
Detailed report: Full report
|
🔨 Build Failure Analysis — PR #1247PR: #1247
Verdict✅ All kernel builds completed successfully. No compilation errors were introduced by this PR. The workflow failure was caused by test infrastructure issues (SSL certificate verification failures when connecting to LAVA test server), not by build errors. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247 Build Status: ✅ SUCCESSThe kernel compilation completed successfully for all configurations. Both the standard and RT kernel builds passed without any compilation errors or warnings. Workflow Failure Root CauseThe GitHub Actions workflow was marked as failed due to LAVA test submission failures, not build failures. All 10 test submission jobs failed with the following SSL certificate error: VerdictNo compilation errors were introduced by this PR. The kernel builds succeeded completely. The workflow failure is due to infrastructure issues (SSL certificate problems with the LAVA test server), not code problems. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247 Build Status: ✅ SUCCESSThe kernel build completed successfully with no compilation errors. All target configurations built cleanly:
Workflow Status: ❌ FAILEDThe workflow was marked as failed due to test infrastructure issues, not build failures:
VerdictZero compilation errors. The PR changes compile cleanly. The workflow failure is due to test infrastructure (LAVA SSL certificate) issues, not code problems introduced by this PR. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247 VerdictNo compilation errors found. The kernel build completed successfully. The workflow failure was caused by LAVA test infrastructure connectivity issues (SSL certificate verification failure), not by compilation errors introduced in this PR. Build Status: ✅ SUCCESS
Test Status: ❌ FAILED (Infrastructure Issue)
📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247 Build Status: ✅ ALL BUILDS SUCCEEDEDThe workflow was marked as failed, but this was not due to compilation errors. All kernel builds completed successfully:
Actual Failure CauseThe workflow failed during the test submission phase, not the build phase. All 10 test jobs failed with: This is an infrastructure/environment issue with the LAVA test submission system, not a code or build problem introduced by this PR. Verdict0 compilation errors. The PR builds cleanly. The workflow failure is unrelated to the code changes and is caused by LAVA SSL certificate verification failures in the test infrastructure. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247
VerdictNo compilation errors found. All 10 kernel builds (base + 9 flat builds) completed successfully. The workflow failure was caused by LAVA test submission failures due to SSL certificate verification errors when connecting to 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247 Build Status: ✅ SUCCESSAll kernel builds completed successfully with zero compilation errors across all target platforms:
Workflow Failure Root CauseThe GitHub Actions workflow was marked as failed due to LAVA test job submission failures, not compilation errors. All 10 test jobs failed with SSL certificate verification errors when attempting to submit jobs to VerdictNo compilation errors were introduced by this PR. The kernel builds successfully for all target platforms. The workflow failure is due to infrastructure issues (LAVA SSL certificate problems), not code quality issues. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247 Verdict✅ Build Successful — No compilation errors detected. All build jobs completed successfully. The PR introduces runtime PM and interconnect bandwidth scaling support for the Qualcomm Crypto Engine (QCE) driver, along with related device tree updates for the Shikra platform. The changes compiled cleanly across all tested configurations. 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247
VerdictThe kernel build completed successfully with no compilation errors. The workflow failure was caused by LAVA test submission failing due to an SSL certificate verification error when connecting to 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1247PR: #1247 VerdictNo compilation errors found. All kernel builds completed successfully. The workflow failure was caused by test infrastructure issues (SSL certificate verification failures when connecting to LAVA), not by compilation problems or code introduced in this PR. Build Status Summary
AnalysisThis PR introduces 5 patches:
All changes compiled cleanly across all target configurations. The only warnings present in the logs are pre-existing device tree warnings unrelated to this PR (graph_port unit address warnings in camera sensor DTSIs). 📎 Detailed analysis: Full report |
|
Regarding the Kernel-checker failure 2.Checking commit: FROMLIST: Revert "FROMLIST: crypto: qce - Add runtime PM and interconnect bandwidth scaling support" 3.Checking commit: BACKPORT: UPSTREAM: crypto: qce - Add runtime PM and interconnect bandwidth scaling support 4.Checking commit: FROMLIST: Revert "FROMLIST: arm64: dts: qcom: shikra: Correct QCE node configuration" Change 2,3,4 are expected as the code change will be different. Regarding pre-merge failure |
Test Matrix
|
a746938
into
qualcomm-linux:qcom-6.18.y
CRs-fixed: 4671922
Signed-off-by: Roopak Houji rhouji@qti.qualcomm.com