Skip to content

QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA - #1284

Open
ichandu1310 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
ichandu1310:Kernel_MONZA_DT
Open

ichandu1310 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
ichandu1310:Kernel_MONZA_DT

Conversation

@ichandu1310

Copy link
Copy Markdown

Added Base camera DT support to MONZA for all ports

CRs-Fixed: 4708308

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4708308 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4708308

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #1284 — validate-patch

PR: #1284

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1284 — QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.
Upstream commit: N/A (vendor-only)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit (QCLINUX: prefix)
Body preserves rationale ⚠️ No commit body present; should explain what camera support is added and why
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved ✅ Author and Signed-off-by match
Backport note (if applicable) N/A Not a backport

Additional commit message issues:

  • ⚠️ Subject uses past tense "Added" instead of imperative mood "Add"
  • ⚠️ Unnecessary capitalization: "Base camera DT support" → "base camera DT support"
  • ⚠️ Missing commit body: should explain which camera sensors/ports are supported and the purpose of this change

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds dtb build rules for monaco-arduino-monza camera variants
monaco-arduino-monza-camera-el2.dtsi ✅ New file: EL2 camera firmware configuration
monaco-arduino-monza-camera-sensor.dtsi ✅ New file: Camera sensor definitions (178 lines)
monaco-arduino-monza-camera.dtsi ✅ New file: Main camera DT support (2612 lines)
monaco-arduino-monza-camx-el2.dtso ✅ New file: Camera overlay for EL2
monaco-arduino-monza-camx.dtso ✅ New file: Camera overlay

Issues

Commit message style:

  1. Subject line should use imperative mood: "Add base camera DT support for MONZA over all ports"
  2. Missing commit body — should describe:
    • Which camera sensors are supported (visible in diff: imx577, ov13b10, ov02b10)
    • Which ports/CSI interfaces are configured
    • Purpose of the EL2 variants
    • Any dependencies or testing performed

Verdict

Merge with minor commit message improvements recommended. The diff content is appropriate for a vendor-only camera enablement patch. Consider adding a commit body to document the scope of camera support being added.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for new vendor-only commit)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: cb7a416d2476d022a449e7d52475c28a6feb390d
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Added Base camera DT support to missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1284 — checker-log-analyzer

PR: #1284
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38394525558

Checker Result Summary
Checker Result Summary
checkpatch ❌ 3 errors, 56 warnings, 1 check
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ❌ Multiple schema validation failures
sparse-check ⏭️ Skipped - no C/H changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX prefix not accepted
tag-check ⚠️ Cannot determine target branch (network unavailable)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1284 - QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38394525558

Checker Result Summary
checkpatch ❌ 3 errors, 56 warnings, 1 check
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ❌ Multiple schema validation failures
sparse-check ⏭️ Skipped - no C/H changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX prefix not accepted
tag-check ⚠️ Cannot determine target branch (network unavailable)

❌ checkpatch

Root cause: Code formatting issues (indentation errors, missing commit description) and 56 undocumented DT compatible strings for camera subsystem components.

Failure details:

c49c122222429eb8e69c69eb0d4ff7f93d05e8b7 total: 3 errors, 56 warnings, 1 checks, 2852 lines checked

ERROR: code indent should use tabs where possible (3 occurrences)
WARNING: Missing commit description - Add an appropriate one
WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented
WARNING: DT compatible string "qcom,cam-sensor" appears un-documented (multiple)
WARNING: DT compatible string "qcom,vfe-lite692" appears un-documented (multiple)
WARNING: DT compatible string "qcom,csid-lite692" appears un-documented (multiple)
WARNING: DT compatible string "qcom,sfe-lite692" appears un-documented (multiple)
WARNING: DT compatible string "qcom,cam-icp" appears un-documented
WARNING: DT compatible string "qcom,cam-icp_v3_0" appears un-documented
WARNING: DT compatible string "qcom,cam-ipe" appears un-documented
WARNING: DT compatible string "qcom,cam-cpas" appears un-documented

Fix:

  1. Indentation errors (3 ERRORs): Replace spaces with tabs in the affected lines. Run:

    git rebase -i bd7f781791361a086a8124a170a5ac30bbdfcb2d
    # mark commit as 'edit'
    # Fix indentation in the DTS files - replace leading spaces with tabs
    git add arch/arm64/boot/dts/qcom/monaco-arduino-monza-*.dtsi
    git commit --amend --no-edit
    git rebase --continue
  2. Missing commit description (WARNING): Add a multi-line commit body explaining what camera support is being added and why. The current commit has only a subject line.

  3. Undocumented DT compatible strings (56 WARNINGs): These are vendor-specific camera subsystem compatible strings. You have two options:

    • Option A (Recommended): Add DT binding YAML files in Documentation/devicetree/bindings/media/qcom/ for each camera component family (qcom,cam-*, qcom,vfe-lite692, qcom,csid-lite692, qcom,sfe-lite692).
    • Option B: If these are vendor-internal components with no upstream binding plans, document this in the commit message. Note that checkpatch will continue to warn, but reviewers will understand the context.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git bd7f781791361a086a8124a170a5ac30bbdfcb2d..c49c122222429eb8e69c69eb0d4ff7f93d05e8b7

❌ dtb-check

Root cause: Multiple schema validation failures for camera subsystem nodes - missing bindings for vendor-specific camera components, invalid status property values, and missing ranges properties in soc@0 child nodes.

Failure details:

Log Summary: Test failed

# Invalid status property (repeated across many camera nodes):
status: 'oneOf' conditional failed, one must be fixed:
  ['ok'] is not of type 'object'
  'ok' is not one of ['okay', 'disabled', 'reserved', 'fail', 'fail-needs-probe']

# Missing bindings:
failed to match any schema with compatible: ['qcom,cam-res-mgr']
failed to match any schema with compatible: ['qcom,cam-req-mgr']
failed to match any schema with compatible: ['qcom,camera']
failed to match any schema with compatible: ['qcom,cam-sync']
failed to match any schema with compatible: ['qcom,cam-cpas']
failed to match any schema with compatible: ['qcom,cam-icp']
failed to match any schema with compatible: ['qcom,cam-ipe']
failed to match any schema with compatible: ['qcom,sfe-lite692']
failed to match any schema with compatible: ['qcom,vfe-lite692']
failed to match any schema with compatible: ['qcom,csid-lite692']

# Missing 'ranges' property (40+ camera nodes):
soc@0 (simple-bus): qcom,cam_smmu: 'ranges' is a required property
soc@0 (simple-bus): qcom,ife-lite4: 'ranges' is a required property
[... 40+ similar errors for camera subsystem nodes ...]

# Pre-existing tree issues (not caused by this PR):
phy@1c04000 (qcom,qcs8300-qmp-gen4x2-pcie-phy): 'vdda-refgen-supply' is a required property
phy@1c14000 (qcom,sa8775p-qmp-gen4x4-pcie-phy): 'vdda-refgen-supply' is a required property
cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
pinctrl@f100000 (qcom,qcs8300-tlmm): Unevaluated properties are not allowed
  ('cam_sensor_active_rst0', 'cam_sensor_mclk0_active', 'cci_i2c_scl0_active', ... were unexpected)

Fix:

  1. Invalid status property: Change all status = "ok"; to status = "okay"; in the camera DTS files. The DT spec requires "okay", not "ok".

  2. Missing ranges property: All camera subsystem nodes under soc@0 need ranges; (empty ranges) because they are children of a simple-bus but don't perform address translation. Add ranges; to each camera node definition.

  3. Missing bindings: Add DT binding YAML files for the camera subsystem components. This is the same issue as checkpatch - you need bindings for:

    • qcom,cam-res-mgr
    • qcom,cam-req-mgr
    • qcom,camera
    • qcom,cam-sync
    • qcom,cam-cpas
    • qcom,cam-icp / qcom,cam-icp_v3_0
    • qcom,cam-ipe
    • qcom,sfe-lite692
    • qcom,vfe-lite692
    • qcom,csid-lite692
  4. Pre-existing issues (PHY, CCI, TLMM): These are baseline tree issues not introduced by this PR. They appear in the log because the new DTB builds expose them. No action needed for this PR.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-arduino-monza-camx.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-arduino-monza-camx-el2.dtb

❌ check-patch-compliance

Root cause: The commit uses QCLINUX: prefix, which is not in the checker's allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.
Commit summary does not start with a required prefix

Fix:

This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:.

If this is a vendor-only change with no upstream equivalent:

  • The QCLINUX: prefix is correct per internal conventions.
  • The checker will always fail for vendor-only commits.
  • No patch change needed — this is expected behavior for vendor-internal work.

If this patch has been (or will be) posted upstream:

  • Change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL.
  • Example:
    FROMLIST: arm64: dts: qcom: Added Base camera DT support to MONZA
    
    [commit body]
    
    Link: https://lore.kernel.org/linux-arm-msm/...
    Signed-off-by: Chandu Idavalapati <ichandu@qti.qualcomm.com>
    

Reproduce locally:

# This checker requires the kernel-checkers repo
git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel-checkers
bash check-patch-compliance.sh --kernel-src /path/to/kernel \
  --base bd7f781791361a086a8124a170a5ac30bbdfcb2d \
  --head c49c122222429eb8e69c69eb0d4ff7f93d05e8b7

⚠️ tag-check

Status: Cannot determine target branch (GitHub API unavailable).

Context: The tag-check validation requires knowing the PR's target branch. If the target branch is not qcom-next or qcom-next-staging, then every commit subject must start with a valid prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:).

Current commit prefix: QCLINUX:

Verdict:

  • If targeting qcom-next or qcom-next-staging → ✅ PASS (prefix not required)
  • If targeting any other branch → ✅ PASS (commit has QCLINUX: prefix)

Verdict

3 blockers must be fixed before merge:

  1. checkpatch: Fix 3 indentation errors (tabs vs spaces), add commit description, and either add DT bindings or document why they're vendor-internal.

  2. dtb-check: Change status = "ok" to status = "okay" throughout, add ranges; to all camera nodes under soc@0, and add DT binding YAML files for camera components.

  3. check-patch-compliance: If this is vendor-only work, the QCLINUX: prefix failure is expected and can be ignored. If posted upstream, change to FROMLIST: and add Link: trailer.

Recommended action order:

  1. Fix status = "ok" → status = "okay" (quick fix, affects dtb-check)
  2. Add ranges; to camera nodes (quick fix, affects dtb-check)
  3. Fix indentation errors (quick fix, affects checkpatch)
  4. Add commit description (quick fix, affects checkpatch)
  5. Add DT binding YAML files for camera components (larger effort, affects both checkpatch and dtb-check)

@shubammm shubammm (shubammm) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks fine

@qlijarvis

Copy link
Copy Markdown

PR #1284 — validate-patch

PR: #1284

Verdict Issues Detailed Report
⚠️ 6 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1284 - QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.
Upstream commit: N/A (vendor-only commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only commit
Body preserves rationale ❌ No commit body — missing description of what camera support is being added and why
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ✅ Author: Chandu Idavalapati ichandu@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds dtb build rules for monaco-arduino-monza camera overlays
monaco-arduino-monza-camera-el2.dtsi ✅ New file: EL2 camera firmware configuration (14 lines)
monaco-arduino-monza-camera-sensor.dtsi ✅ New file: Camera sensor definitions (178 lines)
monaco-arduino-monza-camera.dtsi ✅ New file: Base camera DT support (2612 lines)
monaco-arduino-monza-camx-el2.dtso ✅ New file: Camera overlay for EL2 (16 lines)
monaco-arduino-monza-camx.dtso ✅ New file: Camera overlay (15 lines)

Issues

Commit Message Quality:

  • Missing commit body: The commit message has only a subject line and Signed-off-by: trailer. For a large patch adding 2846 lines of camera support across 6 files, a commit body is essential to explain:
    • What camera hardware is being enabled (sensor models, ports)
    • Why this support is needed
    • Any dependencies or configuration requirements
    • Testing performed

Subject Line Style:

  • Subject uses past tense "Added" instead of imperative mood "Add" (kernel convention)
  • Should be: QCLINUX: arm64: dts: qcom: Add base camera DT support to MONZA over all ports

Integration Presence:

  • Per integration_presence_report.md, this commit is missing from both qcom-next and topics branches
  • For a QCLINUX: vendor commit, this is expected if it's a new feature not yet integrated
  • However, the missing commit body makes it impossible to verify whether this is intentional or an oversight

Verdict

Do not merge without adding a commit body. While the diff content appears valid (proper SPDX headers, consistent file naming, appropriate Makefile changes), the complete absence of a commit message body for a 2846-line patch is a significant documentation gap. The commit should explain what camera hardware is being enabled and provide context for future maintainers.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Added Base camera DT support to missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1284 — checker-log-analyzer

PR: #1284
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38564980642

Checker Result Summary
Checker Result Summary
checkpatch ❌ 13 errors (tabs vs spaces), 65 warnings (undocumented DT strings, missing commit description)
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ 30+ new reg_format errors in monaco-arduino-monza-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ❌ QCLINUX: prefix not valid for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1284 — QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38564980642
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 13 errors (tabs vs spaces), 65 warnings (undocumented DT strings, missing commit description)
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ 30+ new reg_format errors in monaco-arduino-monza-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ❌ QCLINUX: prefix not valid for qcom-6.18.y branch

❌ checkpatch

Root cause: Mixed tabs/spaces indentation and missing commit description.

Failure details:

ERROR: code indent should use tabs where possible (13 occurrences)
  #236-241: monaco-arduino-monza-camera-sensor.dtsi:167-172 (vreg_campin regulator block)
  #244-245: monaco-arduino-monza-camera-sensor.dtsi:175-176 (cam-res-mgr block)
  #752-753: monaco-arduino-monza-camera.dtsi:499-500 (camera node)

WARNING: Missing commit description - Add an appropriate one
WARNING: DT compatible string "qcom,cam-sensor" appears un-documented (×5)
WARNING: DT compatible string "qcom,cam-req-mgr" appears un-documented
WARNING: DT compatible string "qcom,cam-sync" appears un-documented
WARNING: DT compatible string "qcom,cam-tpg1031" appears un-documented (×3)
WARNING: DT compatible string "qcom,csiphy-v1.3.0" appears un-documented (×3)
WARNING: DT compatible string "qcom,cci" appears un-documented (×3)
WARNING: DT compatible string "qcom,msm-cam-smmu" appears un-documented
WARNING: DT compatible string "qcom,msm-cam-smmu-cb" appears un-documented (×4)
WARNING: DT compatible string "qcom,cam-cdm-intf" appears un-documented
WARNING: DT compatible string "qcom,cam-rt-cdm2_1" appears un-documented (×4)
WARNING: DT compatible string "qcom,cam-isp" appears un-documented
WARNING: DT compatible string "qcom,csid692" appears un-documented (×2)
WARNING: DT compatible string "qcom,vfe692" appears un-documented (×2)
WARNING: DT compatible string "qcom,csid-lite692" appears un-documented (×6)
WARNING: DT compatible string "qcom,vfe-lite692" appears un-documented (×6)
WARNING: DT compatible string "qcom,sfe-lite692" appears un-documented (×2)
WARNING: DT compatible string "qcom,cam-icp" appears un-documented
WARNING: DT compatible string "qcom,cam-icp_v3_0" appears un-documented
WARNING: DT compatible string "qcom,cam-ipe" appears un-documented
WARNING: DT compatible string "qcom,cam-cpas" appears un-documented
WARNING: please, no spaces at the start of a line (×13)

total: 13 errors, 65 warnings, 1 checks, 2852 lines checked

Fix:

  1. Indentation errors: Replace leading spaces with tabs in:

    • monaco-arduino-monza-camera-sensor.dtsi:167-172 (vreg_campin regulator)
    • monaco-arduino-monza-camera-sensor.dtsi:175-176 (cam-res-mgr)
    • monaco-arduino-monza-camera.dtsi:499-500 (camera node)
    # Fix spaces → tabs
    sed -i 's/^        /\t/g' arch/arm64/boot/dts/qcom/monaco-arduino-monza-camera-sensor.dtsi
    sed -i 's/^                /\t\t/g' arch/arm64/boot/dts/qcom/monaco-arduino-monza-camera-sensor.dtsi
    sed -i 's/^                /\t\t/g' arch/arm64/boot/dts/qcom/monaco-arduino-monza-camera.dtsi
  2. Missing commit description: Add a commit body explaining what this patch does:

    git commit --amend
    # Add body text, e.g.:
    # "Add base camera device tree support for Monaco (MONZA) platform
    # covering all camera ports: CCI, CSIPHY, CSID, VFE, IFE, SFE, ICP, IPE."
  3. Undocumented DT strings: These are vendor-specific camera driver compatible strings. For a QCLINUX: vendor-only patch, these warnings are expected — the bindings do not exist upstream. No action required unless you plan to upstream the camera driver.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 7883c6ded97781c1d307edeb4ece46093cbb5e60..4f57a9142222f96f23912b1346b5faeee1c1c671

❌ dtb-check

Root cause: reg properties have wrong cell count (16 or 32 bytes) when parent expects 12 bytes (#address-cells=2, #size-cells=1).

Failure details:

monaco-arduino-monza-camera.dtsi:526: qcom,tpg13@acac000:reg: invalid length (32 bytes)
monaco-arduino-monza-camera.dtsi:559: qcom,tpg14@acad000:reg: invalid length (32 bytes)
monaco-arduino-monza-camera.dtsi:592: qcom,tpg15@acae000:reg: invalid length (32 bytes)
monaco-arduino-monza-camera.dtsi:624: qcom,csiphy0@ac9c000:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:665: qcom,csiphy1@ac9e000:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:706: qcom,csiphy2@aca0000:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:746: qcom,cci0@ac13000:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:841: qcom,cci1@ac14000:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:935: qcom,cci2@ac15000:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1156: qcom,rt-cdm0:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1186: qcom,rt-cdm1:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1216: qcom,rt-cdm2:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1246: qcom,rt-cdm3:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1282: qcom,csid0:reg: invalid length (32 bytes)
monaco-arduino-monza-camera.dtsi:1318: qcom,ife0:reg: invalid length (32 bytes)
monaco-arduino-monza-camera.dtsi:1363: qcom,csid1:reg: invalid length (32 bytes)
monaco-arduino-monza-camera.dtsi:1399: qcom,ife1:reg: invalid length (32 bytes)
monaco-arduino-monza-camera.dtsi:1444: qcom,csid-lite0:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1493: qcom,ife-lite0:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1542: qcom,csid-lite1:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1591: qcom,ife-lite1:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1640: qcom,csid-lite2:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1689: qcom,ife-lite2:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1738: qcom,csid-lite3:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1787: qcom,ife-lite3:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1836: qcom,csid-lite4:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1885: qcom,ife-lite4:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1934: qcom,sfe-lite0:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:1975: qcom,sfe-lite1:reg: invalid length (16 bytes)
monaco-arduino-monza-camera.dtsi:2077: qcom,ipe0:reg: invalid length (16 bytes)

Fix:

The parent node (fragment overlay target) has #address-cells = <2>; #size-cells = <1>;, which means each reg entry must be 3 cells (2 address + 1 size) = 12 bytes.

  • 16-byte reg → 4 cells → change to 3 cells (e.g., reg = <0 0xac9c000 0x1000>;)
  • 32-byte reg → 8 cells → change to 3 cells (e.g., reg = <0 0xacac000 0x1000>;)

Example fix for qcom,csiphy0@ac9c000:

-reg = <0xac9c000 0x1000 0xac9d000 0x1000>;  // 4 cells = 16 bytes
+reg = <0 0xac9c000 0x1000>;                 // 3 cells = 12 bytes

Apply this pattern to all 30+ nodes listed above.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-arduino-monza-camera.dtb

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the allowed list (FROMLIST, FROMGIT, UPSTREAM, BACKPORT).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.
Commit summary does not start with a required prefix

Fix:

check-patch-compliance enforces upstream-linkable prefixes only. QCLINUX: is a vendor-internal prefix and will always fail this checker. This is a known limitation of the checker for vendor-only commits.

Options:

  1. If this patch is posted upstream (lore.kernel.org), change prefix to FROMLIST: and add Link: trailer.
  2. If this is truly vendor-only with no upstream equivalent, the checker will always fail — this is expected behavior.

❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires a valid subject prefix. QCLINUX: is not a recognized prefix for this branch.

Failure details:

Commit 2d1029833d3a ("QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.")
Subject line does not start with a required prefix.
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Wait — contradiction detected: The skill reference says QCLINUX: is a valid prefix for tag-check (Step 2.7), but check-patch-compliance rejects it. Let me re-read the skill...

Correction: After re-reading the skill, I see:

  • tag-check (Step 2.7) accepts: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:
  • check-patch-compliance (Step 2.6) accepts only: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:

So QCLINUX: passes tag-check but fails check-patch-compliance. This is correct.

Fix:

For qcom-6.18.y branch:

  • QCLINUX: prefix is valid for tag-check.
  • QCLINUX: prefix fails check-patch-compliance (known limitation).

No action needed for tag-check — it passes. The failure is only in check-patch-compliance.


Verdict

3 blockers must be fixed before merge:

  1. checkpatch: Fix 13 indentation errors (spaces → tabs) and add commit description.
  2. dtb-check: Fix 30+ reg property cell counts in monaco-arduino-monza-camera.dtsi.
  3. check-patch-compliance: QCLINUX: prefix will always fail this checker for vendor-only commits — this is a known limitation. If the patch is posted upstream, change to FROMLIST: + add Link: trailer. Otherwise, accept the checker failure.

tag-check: ✅ PASS — QCLINUX: is a valid prefix for qcom-6.18.y branch.

@qlijarvis

Copy link
Copy Markdown

PR #1284 — validate-patch

PR: #1284

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1284 - QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.
Upstream commit: N/A (vendor-only)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit (QCLINUX: prefix)
Body preserves rationale ⚠️ Minimal commit message; no description of what camera support is being added
Fixes tag present/correct N/A Not a fix
Authorship preserved ✅ Vendor commit; authorship is correct
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds dtb build rules for monaco-arduino-monza camera overlays
monaco-arduino-monza-camera-el2.dtsi ✅ New file: camera firmware IOMMU and CPAS config for EL2
monaco-arduino-monza-camera-sensor.dtsi ✅ New file: camera sensor definitions (177 lines)
monaco-arduino-monza-camera.dtsi ✅ New file: main camera DT support (2612 lines)
monaco-arduino-monza-camx-el2.dtso ✅ New file: camera overlay for EL2 (16 lines)
monaco-arduino-monza-camx.dtso ✅ New file: camera overlay (15 lines)

Issues

  • Commit message lacks detail: The subject line is truncated ("Added Base camera DT support to MONZA over all ports") and the body is empty. For a 2845-line addition spanning 6 files, the commit message should explain:
    • Which camera sensors are being added (imx577, ov13b10, etc. visible in the diff)
    • What "all ports" means (CSI ports 0-3?)
    • Why both .dtsi includes and .dtso overlays are needed
    • Any hardware dependencies or board-specific configuration details

Verdict

Vendor-only commit with correct QCLINUX: prefix. The code changes are substantial (2845 lines) and appear well-structured, but the commit message is minimal and should be expanded to document what camera hardware support is being added and why.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Added Base camera DT support to missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1284 — checker-log-analyzer

PR: #1284
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38712409338

Checker Result Summary
Checker Result Summary
checkpatch ❌ 53 warnings: missing commit description + 23 undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ❌ 23 camera-related compatible strings fail schema validation
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check N/A Cannot determine target branch (network unavailable); manual verification needed

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1284 - QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38712409338

Checker Result Summary
checkpatch ❌ 53 warnings: missing commit description + 23 undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ❌ 23 camera-related compatible strings fail schema validation
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check N/A Cannot determine target branch (network unavailable); manual verification needed

❌ checkpatch

Root cause: Missing commit description and 23 undocumented camera subsystem DT compatible strings.

Failure details:

WARNING: Missing commit description - Add an appropriate one

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented (×5 occurrences)
WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented
WARNING: DT compatible string "qcom,camera" appears un-documented
WARNING: DT compatible string "qcom,cam-req-mgr" appears un-documented
WARNING: DT compatible string "qcom,cam-sync" appears un-documented
WARNING: DT compatible string "qcom,cam-tpg1031" appears un-documented (×3)
WARNING: DT compatible string "qcom,csiphy-v1.3.0" appears un-documented (×3)
WARNING: DT compatible string "qcom,csiphy" appears un-documented (×3)
WARNING: DT compatible string "qcom,cci" appears un-documented
WARNING: DT compatible string "qcom,cam-cpas" appears un-documented
WARNING: DT compatible string "qcom,cam-isp" appears un-documented
WARNING: DT compatible string "qcom,cam-icp_v3_0" appears un-documented
WARNING: DT compatible string "qcom,cam-icp" appears un-documented
WARNING: DT compatible string "qcom,cam-ipe" appears un-documented
WARNING: DT compatible string "qcom,cam-rt-cdm2_1" appears un-documented
WARNING: DT compatible string "qcom,cam-cdm-intf" appears un-documented
WARNING: DT compatible string "qcom,csid692" appears un-documented
WARNING: DT compatible string "qcom,vfe692" appears un-documented
WARNING: DT compatible string "qcom,csid-lite692" appears un-documented
WARNING: DT compatible string "qcom,vfe-lite692" appears un-documented
WARNING: DT compatible string "qcom,sfe-lite692" appears un-documented
WARNING: DT compatible string "qcom,msm-cam-smmu" appears un-documented
WARNING: DT compatible string "qcom,msm-cam-smmu-cb" appears un-documented

6d098b51d81f86378e9e62351c34781ece45d1d4 total: 0 errors, 53 warnings, 0 checks, 2851 lines checked

Fix:

  1. Add commit description:

    git commit --amend
    # Add a multi-line description explaining:
    # - What camera hardware is being enabled
    # - Which ports are supported
    # - Any dependencies or prerequisites
  2. Document DT compatible strings:

    All 23 camera subsystem compatible strings need DT binding YAML documentation in Documentation/devicetree/bindings/. This is a substantial effort requiring:

    • Create binding files for each camera component (sensor, ISP, CPAS, ICP, etc.)
    • Define required/optional properties for each compatible string
    • Add example DTS snippets
    • Ensure YAML schema validation passes

    Alternative approach (if bindings exist downstream):

    • If these bindings exist in a vendor tree or are pending upstream submission, consider splitting this work:
      1. Submit binding documentation first (separate patch series)
      2. Then submit DTS changes that reference the bindings

    Note: For QCLINUX: vendor-only changes, undocumented compatible strings may be acceptable in internal trees, but checkpatch will always flag them.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a4d631a5f8fd..d69276a1115f

❌ dtb-check

Root cause: All 23 camera-related compatible strings fail schema validation because no DT binding YAML files exist for them.

Failure details:

arch/arm64/boot/dts/qcom/monaco-arduino-monza-camx.dtb: 
  /soc@0/qcom,cam-sensor: failed to match any schema with compatible: ['qcom,cam-sensor']
  /soc@0/qcom,cam-res-mgr: failed to match any schema with compatible: ['qcom,cam-res-mgr']
  /soc@0/qcom,cam-cpas: failed to match any schema with compatible: ['qcom,cam-cpas']
  /soc@0/qcom,ipe0: failed to match any schema with compatible: ['qcom,cam-ipe']
  /soc@0/qcom,icp: failed to match any schema with compatible: ['qcom,cam-icp_v3_0']
  /soc@0/qcom,cam-icp: failed to match any schema with compatible: ['qcom,cam-icp']
  /soc@0/qcom,sfe-lite1: failed to match any schema with compatible: ['qcom,sfe-lite692']
  /soc@0/qcom,sfe-lite0: failed to match any schema with compatible: ['qcom,sfe-lite692']
  /soc@0/qcom,ife-lite4: failed to match any schema with compatible: ['qcom,vfe-lite692']
  /soc@0/qcom,csid-lite4: failed to match any schema with compatible: ['qcom,csid-lite692']
  /soc@0/qcom,ife1: failed to match any schema with compatible: ['qcom,vfe692']
  /soc@0/qcom,csid1: failed to match any schema with compatible: ['qcom,csid692']
  /soc@0/qcom,cci: failed to match any schema with compatible: ['qcom,cci', 'simple-bus']
  /soc@0/qcom,cam-req-mgr: failed to match any schema with compatible: ['qcom,cam-req-mgr']
  /soc@0/qcom,camera-main: failed to match any schema with compatible: ['qcom,camera']
  /soc@0/qcom,cam-sync: failed to match any schema with compatible: ['qcom,cam-sync']
  /soc@0/qcom,cam-tpg1031: failed to match any schema with compatible: ['qcom,cam-tpg1031']
  /soc@0/csiphy@ac65000: failed to match any schema with compatible: ['qcom,csiphy-v1.3.0', 'qcom,csiphy']
  /soc@0/qcom,cam-isp: failed to match any schema with compatible: ['qcom,cam-isp']
  /soc@0/qcom,cam-cdm-intf: failed to match any schema with compatible: ['qcom,cam-cdm-intf']
  /soc@0/qcom,cam-rt-cdm2_1: failed to match any schema with compatible: ['qcom,cam-rt-cdm2_1']
  /soc@0/qcom,msm-cam-smmu: failed to match any schema with compatible: ['qcom,msm-cam-smmu', 'simple-bus']
  /soc@0/qcom,msm-cam-smmu-cb: failed to match any schema with compatible: ['qcom,msm-cam-smmu-cb']

Log Summary: Test failed

Fix:

Create DT binding YAML files for all camera subsystem components. Required bindings:

Core camera framework:

  • Documentation/devicetree/bindings/media/qcom,camera.yaml (main camera node)
  • Documentation/devicetree/bindings/media/qcom,cam-req-mgr.yaml (request manager)
  • Documentation/devicetree/bindings/media/qcom,cam-sync.yaml (sync framework)
  • Documentation/devicetree/bindings/media/qcom,cam-res-mgr.yaml (resource manager)

Camera sensor & PHY:

  • Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml
  • Documentation/devicetree/bindings/media/qcom,csiphy.yaml (CSI PHY)
  • Documentation/devicetree/bindings/media/qcom,cci.yaml (Camera Control Interface)

ISP pipeline components:

  • Documentation/devicetree/bindings/media/qcom,cam-cpas.yaml (Camera Processor Application Subsystem)
  • Documentation/devicetree/bindings/media/qcom,cam-isp.yaml (ISP)
  • Documentation/devicetree/bindings/media/qcom,vfe692.yaml (Video Front End)
  • Documentation/devicetree/bindings/media/qcom,csid692.yaml (CSID)
  • Documentation/devicetree/bindings/media/qcom,sfe-lite692.yaml (SFE Lite)

Image processing:

  • Documentation/devicetree/bindings/media/qcom,cam-icp.yaml (Image Control Processor)
  • Documentation/devicetree/bindings/media/qcom,cam-ipe.yaml (Image Processing Engine)

CDM & TPG:

  • Documentation/devicetree/bindings/media/qcom,cam-cdm.yaml (Context Detection Manager)
  • Documentation/devicetree/bindings/media/qcom,cam-tpg.yaml (Test Pattern Generator)

SMMU:

  • Documentation/devicetree/bindings/iommu/qcom,msm-cam-smmu.yaml

Each binding must define:

  • compatible strings
  • Required properties (reg, interrupts, clocks, etc.)
  • Optional properties
  • Example DTS snippet

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-arduino-monza-camx.dtb

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA over all ports.
Commit summary does not start with a required prefix

Fix:

This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes and does not recognize vendor-internal prefixes like QCLINUX: or PENDING:.

Options:

  1. If this is vendor-only code with no upstream equivalent:

    • The checker will always fail for QCLINUX: commits
    • This is expected behavior for vendor-internal changes
    • No patch change needed; acknowledge the limitation
  2. If camera DT support is posted or planned for upstream:

    • Change prefix to FROMLIST: and add Link: <lore-url> to commit body
    • Requires posting the patch series to the appropriate mailing list first
  3. If camera DT support exists in a maintainer tree:

    • Change prefix to FROMGIT: and add Link: <git-tree-url> to commit body

Note: Given the extensive undocumented bindings, this appears to be vendor-specific camera enablement not yet ready for upstream, so the QCLINUX: prefix is appropriate and the checker failure is expected.

Reproduce locally:

# The checker script is in the kernel-config repo
./scripts/check-patch-compliance.sh <base_sha> <head_sha>

⚠️ tag-check (Manual Verification Required)

Status: Cannot determine target branch automatically (GitHub API unavailable).

Action required:

  1. Determine the PR target branch:

    gh pr view 1284 --repo qualcomm-linux/kernel --json baseRefName -q .baseRefName
  2. If target branch is qcom-next or qcom-next-staging:

    • ✅ Subject prefix check is not required → PASS
    • The QCLINUX: prefix is acceptable
  3. If target branch is any other branch (e.g., qcom-mainline, qcom-stable-*):

    • ❌ Subject prefix check is mandatory
    • Every commit must start with: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:
    • Current commit has QCLINUX: prefix → ✅ PASS

Likely outcome: Given the vendor-specific camera enablement nature of this PR, it is most likely targeting qcom-next or qcom-next-staging, in which case the tag-check would PASS (not required for those branches).


Verdict

3 blockers must be addressed before merge:

  1. checkpatch (critical): Add commit description explaining the camera enablement scope and purpose.

  2. checkpatch + dtb-check (major): 23 undocumented camera subsystem DT compatible strings require binding YAML documentation. This is substantial work requiring:

    • Creating ~15-20 binding YAML files covering all camera components
    • Defining properties, constraints, and examples for each
    • Ensuring schema validation passes

    Recommendation: Consider splitting this work:

    • Submit binding documentation as a separate patch series first
    • Then submit DTS changes that reference the bindings
    • Or, if this is vendor-internal code, acknowledge that checkpatch/dtb-check will fail for undocumented vendor bindings
  3. check-patch-compliance (known limitation): The QCLINUX: prefix failure is expected for vendor-only changes. No action needed unless the code is intended for upstream submission.

Estimated effort: High — requires creating comprehensive DT binding documentation for the entire camera subsystem before this DTS change can pass CI cleanly.

@shubammm shubammm (shubammm) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change seems fine

@ichandu1310
ichandu1310 force-pushed the Kernel_MONZA_DT branch 2 times, most recently from 7546915 to b103dd5 Compare October 15, 2026 12:22
@qlijarvis

Copy link
Copy Markdown

PR #1284 — validate-patch

PR: #1284

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1284 - QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA
Upstream commit: N/A (vendor-only change)
Verdict: ⚠️ N/A — QCLINUX: vendor-only commit

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix — no upstream source
Body preserves rationale ✅ Describes camera subsystem DT support for MONZA
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved N/A Original vendor contribution
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds camera overlay build targets
monaco-arduino-monza-camera-el2.dtsi ✅ New camera EL2 configuration
monaco-arduino-monza-camera-sensor.dtsi ✅ New camera sensor definitions
monaco-arduino-monza-camera.dtsi ✅ New base camera subsystem DT (2612 lines)
monaco-arduino-monza-camx-el2.dtso ✅ New camera overlay for EL2
monaco-arduino-monza-camx.dtso ✅ New camera overlay

Issues

None — this is a vendor-only devicetree addition with the correct QCLINUX: prefix.

Verdict

This is a vendor-only commit correctly prefixed with QCLINUX:. No upstream validation is applicable. The commit adds comprehensive camera subsystem devicetree support for the MONZA platform, including sensor definitions, overlays, and build infrastructure.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for new vendor contribution pending merge)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Added Base camera DT support to missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1284 — checker-log-analyzer

PR: #1284
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38734352698

Checker Result Summary
Checker Result Summary
checkpatch ❌ 53 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ Multiple reg_format errors: reg property cell count mismatch
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ✅ PASS (qcom-6.18.y allows QCLINUX:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1284 - QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38734352698
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 53 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ Multiple reg_format errors: reg property cell count mismatch
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ✅ PASS (qcom-6.18.y allows QCLINUX:)

❌ checkpatch

Root cause: 53 camera-related DT compatible strings are undocumented in Documentation/devicetree/bindings/vendor-prefixes.yaml or lack binding YAML files.

Failure details:

WARNING: DT compatible string "qcom,camera" appears un-documented
WARNING: DT compatible string "qcom,cam-req-mgr" appears un-documented
WARNING: DT compatible string "qcom,cam-sync" appears un-documented
WARNING: DT compatible string "qcom,cam-tpg1031" appears un-documented (×3)
WARNING: DT compatible string "qcom,csiphy-v1.3.0" appears un-documented (×3)
WARNING: DT compatible string "qcom,csiphy" appears un-documented (×3)
WARNING: DT compatible string "qcom,cci" appears un-documented (×3)
WARNING: DT compatible string "qcom,msm-cam-smmu" appears un-documented
WARNING: DT compatible string "qcom,msm-cam-smmu-cb" appears un-documented (×4)
WARNING: DT compatible string "qcom,cam-cdm-intf" appears un-documented
WARNING: DT compatible string "qcom,cam-rt-cdm2_1" appears un-documented (×4)
WARNING: DT compatible string "qcom,cam-isp" appears un-documented
WARNING: DT compatible string "qcom,csid692" appears un-documented (×2)
WARNING: DT compatible string "qcom,vfe692" appears un-documented (×2)
WARNING: DT compatible string "qcom,csid-lite692" appears un-documented (×5)
WARNING: DT compatible string "qcom,vfe-lite692" appears un-documented (×5)
WARNING: DT compatible string "qcom,sfe-lite692" appears un-documented (×2)
WARNING: DT compatible string "qcom,cam-icp" appears un-documented
WARNING: DT compatible string "qcom,cam-icp_v3_0" appears un-documented
WARNING: DT compatible string "qcom,cam-ipe" appears un-documented
WARNING: DT compatible string "qcom,cam-cpas" appears un-documented

total: 0 errors, 53 warnings, 0 checks, 2851 lines checked

Fix: Add DT binding YAML files for all camera subsystem compatible strings. These are vendor-specific Qualcomm camera hardware blocks that require proper documentation:

  1. Create Documentation/devicetree/bindings/media/qcom,camera.yaml covering:

    • qcom,camera (top-level camera node)
    • qcom,cam-req-mgr (request manager)
    • qcom,cam-sync (synchronization)
    • qcom,cam-isp (ISP)
    • qcom,cam-icp (ICP processor)
    • qcom,cam-ipe (IPE)
    • qcom,cam-cpas (CPAS)
  2. Create Documentation/devicetree/bindings/media/qcom,csiphy.yaml for:

    • qcom,csiphy-v1.3.0
    • qcom,csiphy
  3. Create Documentation/devicetree/bindings/media/qcom,cci.yaml for:

    • qcom,cci
  4. Create Documentation/devicetree/bindings/media/qcom,cam-tpg.yaml for:

    • qcom,cam-tpg1031
  5. Create Documentation/devicetree/bindings/media/qcom,cam-csid.yaml for:

    • qcom,csid692
    • qcom,csid-lite692
  6. Create Documentation/devicetree/bindings/media/qcom,cam-vfe.yaml for:

    • qcom,vfe692
    • qcom,vfe-lite692
    • qcom,sfe-lite692
  7. Create Documentation/devicetree/bindings/media/qcom,cam-cdm.yaml for:

    • qcom,cam-cdm-intf
    • qcom,cam-rt-cdm2_1
  8. Create Documentation/devicetree/bindings/iommu/qcom,msm-cam-smmu.yaml for:

    • qcom,msm-cam-smmu
    • qcom,msm-cam-smmu-cb

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git c38d121d0c6c7f77298bf9028161b14a9793f2bf..b103dd5a472b9412a81c2179bcc837a9165a8f87

❌ dtb-check

Root cause: All camera device nodes have reg properties with incorrect cell counts — they use 4 cells (2 address + 2 size) when the parent soc@0 expects 3 cells (2 address + 1 size).

Failure details:

monaco-arduino-monza-camera.dtsi:526: Warning (reg_format): /fragment@1/__overlay__/qcom,tpg13@acac000:reg: 
  property has invalid length (32 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:559: Warning (reg_format): /fragment@1/__overlay__/qcom,tpg14@acad000:reg: 
  property has invalid length (32 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:592: Warning (reg_format): /fragment@1/__overlay__/qcom,tpg15@acae000:reg: 
  property has invalid length (32 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:624: Warning (reg_format): /fragment@1/__overlay__/qcom,csiphy0@ac9c000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:665: Warning (reg_format): /fragment@1/__overlay__/qcom,csiphy1@ac9e000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:706: Warning (reg_format): /fragment@1/__overlay__/qcom,csiphy2@aca0000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:746: Warning (reg_format): /fragment@1/__overlay__/qcom,cci0@ac13000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:841: Warning (reg_format): /fragment@1/__overlay__/qcom,cci1@ac14000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
monaco-arduino-monza-camera.dtsi:935: Warning (reg_format): /fragment@1/__overlay__/qcom,cci2@ac15000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
... (30+ similar errors for csid, ife, ife-lite, sfe-lite, rt-cdm, ipe nodes)

Also:
monaco-arduino-monza-camx.dtb: /soc@0/qcom,cam-sync: failed to match any schema with compatible: ['qcom,cam-sync']
monaco-arduino-monza-camx.dtb: qcom,cam-sync (qcom,cam-sync): status: 'ok' is not one of ['okay', 'disabled', 'reserved', 'fail', 'fail-needs-probe']
monaco-arduino-monza-camx.dtb: /soc@0/qcom,cam-req-mgr: failed to match any schema with compatible: ['qcom,cam-req-mgr']
monaco-arduino-monza-camx.dtb: qcom,cam-req-mgr (qcom,cam-req-mgr): status: 'ok' is not one of ['okay', 'disabled', 'reserved', 'fail', 'fail-needs-probe']
monaco-arduino-monza-camx.dtb: /soc@0/qcom,camera-main: failed to match any schema with compatible: ['qcom,camera']
monaco-arduino-monza-camx.dtb: qcom,camera-main (qcom,camera): status: 'ok' is not one of ['okay', 'disabled', 'reserved', 'fail', 'fail-needs-probe']
monaco-arduino-monza-camx.dtb: cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
monaco-arduino-monza-camx.dtb: cci@ac14000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
monaco-arduino-monza-camx.dtb: cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
monaco-arduino-monza-camx.dtb: pinctrl@f100000 (qcom,qcs8300-tlmm): Unevaluated properties are not allowed 
  ('cam_sensor_active_rst0', 'cam_sensor_mclk0_active', 'cci_i2c_scl0_active', ... were unexpected)

Fix:

  1. Fix reg cell count — Change all reg properties from 4-cell to 3-cell format:

    - reg = <0x0 0xacac000 0x0 0x1000>;  // 4 cells (wrong)
    + reg = <0x0 0xacac000 0x1000>;      // 3 cells (correct)

    Apply this fix to all 30+ camera device nodes in monaco-arduino-monza-camera.dtsi.

  2. Fix status property — Change status = "ok"; to status = "okay"; (standard DT value) in:

    • qcom,cam-sync
    • qcom,cam-req-mgr
    • qcom,camera-main
  3. Fix CCI clock-names — The qcom,qcs8300-cci binding expects clock-names to start with "ahb". Verify the clock-names order in cci@ac13000, cci@ac14000, cci@ac15000.

  4. TLMM unevaluated properties — This is a recurring tree-wide issue (see log-patterns.md Section 8). The qcom,qcs8300-tlmm binding uses unevaluatedProperties: false and doesn't declare camera sensor pin state names. This is a pre-existing binding limitation, not introduced by this PR. The binding needs to be updated to allow cam_sensor_*, cci_i2c_*, and mclk* pin state names via patternProperties.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-arduino-monza-camx.dtb

❌ check-patch-compliance

Root cause: The commit subject uses the QCLINUX: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Added Base camera DT support to MONZA
Commit summary does not start with a required prefix

Fix: This is a known checker limitation for vendor-only commits. The check-patch-compliance checker only accepts upstream-linkable prefixes and always fails for QCLINUX: and PENDING: commits. Since this is a vendor-specific camera DT addition with no upstream equivalent, the QCLINUX: prefix is correct per internal conventions. No patch change needed — this failure is expected for vendor-only work.

Note: If this patch is later posted upstream, change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL.


Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Add DT binding YAML files for all 53 undocumented camera compatible strings (or suppress warnings if bindings are vendor-internal and not upstreamable).
  2. dtb-check — Fix reg property cell count (4-cell → 3-cell) for all 30+ camera device nodes.
  3. dtb-check — Fix status = "ok" → status = "okay" for 3 nodes.

Known limitations (not blockers):

  • check-patch-compliance failure is expected for QCLINUX: prefix (vendor-only commit).
  • TLMM unevaluated properties are a pre-existing tree issue, not introduced by this PR.

  Add devicetree support for the camera subsystem on MONZA, covering
  all available camera ports. This includes:

  - CCI, CSIPHY, CSID, VFE/SFE (lite) nodes for the ISP pipeline
  - Camera sensor nodes across cam_cci0/1/2 ports

Signed-off-by: Chandu Idavalapati <ichandu@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1284 — validate-patch

PR: #1284

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1284 — QCLINUX: arm64: dts: qcom: monza: Added Base camera DT support
Upstream commit: N/A (vendor-only QCLINUX: commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit; no upstream source
Body preserves rationale ✅ Clear description of camera subsystem additions
Fixes tag present/correct N/A New feature addition; no Fixes tag required
Authorship preserved ✅ Author: Chandu Idavalapati; Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds dtb build targets for monza camera variants
monaco-arduino-monza-camera-el2.dtsi ✅ New file: EL2 camera firmware config (14 lines)
monaco-arduino-monza-camera-sensor.dtsi ✅ New file: Camera sensor definitions (177 lines)
monaco-arduino-monza-camera.dtsi ✅ New file: Camera subsystem nodes (2612 lines)
monaco-arduino-monza-camx-el2.dtso ✅ New file: CamX EL2 overlay (16 lines)
monaco-arduino-monza-camx.dtso ✅ New file: CamX overlay (15 lines)

Issues

  • Missing from qcom-next/topics: This commit is not present in qcom-next or any topic branch. Even vendor-only commits should typically land in qcom-next or a topic branch before being merged to ensure proper integration testing and review.

Verdict

This is a vendor-only devicetree addition for Monza camera support. The commit message is clear and properly formatted for a QCLINUX: commit. However, the commit is missing from both qcom-next and topic branches, which raises integration concerns. Recommend verifying this commit has been properly reviewed and tested before merging.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: monza: Added Base camera DT missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1284 — checker-log-analyzer

PR: #1284
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38742913372

Checker Result Summary
Checker Result Summary
checkpatch ❌ 52 undocumented DT compatible strings
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ❌ ~300 reg_format errors in new camera DTSI
sparse-check ⏭️ Skipped - no C/H changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not accepted (known limitation)
tag-check ⚠️ QCLINUX: is valid for vendor-only commits

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1284 - QCLINUX: arm64: dts: qcom: monza: Added Base camera DT support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38742913372
Target Branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 52 undocumented DT compatible strings
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ❌ ~300 reg_format errors in new camera DTSI
sparse-check ⏭️ Skipped - no C/H changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not accepted (known limitation)
tag-check ⚠️ QCLINUX: is valid for vendor-only commits

❌ checkpatch

Root cause: 52 camera subsystem compatible strings are not documented in DT bindings.

Failure details:

WARNING: DT compatible string "qcom,csid-lite692" appears un-documented
WARNING: DT compatible string "qcom,vfe-lite692" appears un-documented
WARNING: DT compatible string "qcom,csid692" appears un-documented
WARNING: DT compatible string "qcom,vfe692" appears un-documented
WARNING: DT compatible string "qcom,sfe-lite692" appears un-documented
WARNING: DT compatible string "qcom,cam-icp" appears un-documented
WARNING: DT compatible string "qcom,cam-icp_v3_0" appears un-documented
WARNING: DT compatible string "qcom,cam-ipe" appears un-documented
WARNING: DT compatible string "qcom,cam-cpas" appears un-documented
... (52 total warnings for 23 unique compatible strings)

Unique undocumented compatible strings:

  • qcom,csid-lite692, qcom,vfe-lite692, qcom,sfe-lite692
  • qcom,csid692, qcom,vfe692
  • qcom,cam-cpas, qcom,cam-icp, qcom,cam-icp_v3_0, qcom,cam-ipe
  • qcom,cam-isp, qcom,cam-req-mgr, qcom,cam-res-mgr, qcom,cam-sync
  • qcom,cam-cdm-intf, qcom,cam-rt-cdm2_1
  • qcom,cam-sensor, qcom,cam-tpg1031
  • qcom,camera, qcom,cci, qcom,csiphy, qcom,csiphy-v1.3.0
  • qcom,msm-cam-smmu, qcom,msm-cam-smmu-cb

Fix: Add DT binding YAML files for the camera subsystem components:

# Create bindings for each camera component family:
Documentation/devicetree/bindings/media/qcom,csid.yaml
Documentation/devicetree/bindings/media/qcom,vfe.yaml
Documentation/devicetree/bindings/media/qcom,sfe.yaml
Documentation/devicetree/bindings/media/qcom,cam-cpas.yaml
Documentation/devicetree/bindings/media/qcom,cam-icp.yaml
Documentation/devicetree/bindings/media/qcom,cci.yaml
Documentation/devicetree/bindings/media/qcom,csiphy.yaml
# ... etc for remaining components

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git c38d121d0c6c..5527ba51ae02

❌ dtb-check

Root cause: ~300 reg_format errors in monaco-arduino-monza-camera.dtsi — reg properties have incorrect cell counts that don't match parent #address-cells/#size-cells.

Failure details:

Warning (reg_format): /fragment@1/__overlay__/qcom,tpg13@acac000:reg: 
  property has invalid length (32 bytes) (#address-cells == 2, #size-cells == 1)
Warning (reg_format): /fragment@1/__overlay__/qcom,csiphy0@ac9c000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
Warning (reg_format): /fragment@1/__overlay__/qcom,cci0@ac13000:reg: 
  property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
... (~300 similar errors across all camera nodes)

Analysis:
The parent overlay fragment has #address-cells = <2> and #size-cells = <1>, meaning each reg entry should be 3 cells (2 for address + 1 for size).

However, the camera nodes are using:

  • 4 cells (32 bytes) for some nodes → should be 3 cells
  • 2 cells (16 bytes) for other nodes → should be 3 cells

Fix: Correct all reg properties in arch/arm64/boot/dts/qcom/monaco-arduino-monza-camera.dtsi to use 3-cell format:

// Wrong (4 cells):
reg = <0x0 0xacac000 0x0 0x1000>;

// Correct (3 cells):
reg = <0x0 0xacac000 0x1000>;

// Wrong (2 cells):
reg = <0xac9c000 0x1000>;

// Correct (3 cells):
reg = <0x0 0xac9c000 0x1000>;

Apply this fix to all ~100 camera nodes in the DTSI file.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-arduino-monza-camx.dtbo

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: monza: Added Base camera DT support
Commit summary does not start with a required prefix

Analysis:
This is a known checker limitation for vendor-only commits. The check-patch-compliance checker only accepts upstream-linkable prefixes and will always fail for QCLINUX: commits.

Context:

  • Target branch: qcom-6.18.y (not qcom-next or qcom-next-staging)
  • Commit type: Vendor-only camera DT addition with no upstream equivalent
  • Prefix used: QCLINUX: (valid for vendor-only work)

Verdict: This failure is expected and acceptable for vendor-only commits. The QCLINUX: prefix is correct for this use case. No patch change needed.


⚠️ tag-check (manual check)

Status: ⚠️ PASS with caveat

Analysis:
The commit subject starts with QCLINUX:, which is a valid prefix for vendor-only changes. Since the target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), a subject prefix is required.

Valid prefixes for non-qcom-next branches:

  • FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT: (upstream-linkable)
  • QCLINUX:, PENDING:, WORKAROUND: (vendor-only)

The commit correctly uses QCLINUX: for a vendor-specific camera DT addition.

Verdict: ✅ Subject prefix requirement satisfied.


Verdict

3 blockers must be fixed before merge:

  1. checkpatch (blocker): Add DT binding YAML files for 23 undocumented camera compatible strings. This is required for upstream-style kernel development.

  2. dtb-check (blocker): Fix ~300 reg_format errors by correcting all reg properties in monaco-arduino-monza-camera.dtsi to use 3-cell format matching parent #address-cells=<2> and #size-cells=<1>.

  3. check-patch-compliance (not a blocker): The QCLINUX: prefix failure is expected and acceptable for vendor-only commits. This is a known checker limitation.

Recommendation: Fix the DT bindings and reg format errors before merging. The check-patch-compliance failure can be ignored as it's a known limitation for QCLINUX: commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants