Repository navigation
About error handling in custom module loader #848
Description
Hello, I want to know that how to deal with errors (such as invalid path, file busy, etc.) inside module loader.
Since it is defined as
typedef JSModuleDef *JSModuleLoaderFunc(JSContext *ctx, const char *module_name, void *opaque);
is it right to return nullptr when some error occurs? I've tried before calling JS_LoadModule, which returned a promise rejection as expected.
And what about JSModuleNormalizeFunc?
Activity
saghul commentedon Jan 24, 2025
Yes, you should throw an exception and return NULL. I recently added some error handling for similar cases (when setting the meta object fails): ab48ede
Same thing. The default one can also fail in case of memory errors for example, and it will simply return NULL with the OOM exception thrown.