Repository navigation
fix(object): check extensibility before integrity properties - #1820
Open
SomSamantray wants to merge 1 commit into
Open
SomSamantray wants to merge 1 commit into
SomSamantray wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object.isFrozen and Object.isSealed now check proxy extensibility first, matching TestIntegrityLevel. Extensible objects return false without invoking
ownKeysor property-descriptor traps.The issue reproduction now logs
isExtensiblefirst for both methods. The configuredtests.confsuite reports 0/120 errors (9 excluded), and the new regression case passes; standalone execution of the fulltest_builtin.jsfile later stops at its unavailableqjs.getStringKindglobal.Fixes #1799.
AI disclosure: Prepared with assistance from OpenAI Codex.