Repository navigation
Fix string matching property access order - #1848
Open
trestoncuzzort wants to merge 1 commit into
Open
trestoncuzzort wants to merge 1 commit into
trestoncuzzort wants to merge 1 commit into
Conversation
Check matchAll's global flag before looking up Symbol.matchAll. Use RegExpCreate semantics for fallback matching instead of the RegExp constructor, avoiding extra Symbol.match and source lookups. Add regressions for observable getter order, pattern conversion, custom matchers and exception cleanup.
trestoncuzzort
marked this pull request as ready for review
October 26, 2026 15:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1796.
Check
IsRegExpand the global flag before readingSymbol.matchAll. Implement theRegExpCreatefallback inmatch,searchandmatchAllby converting and compiling the pattern directly, avoiding extraSymbol.matchandsourcereads and honoring an overridden RegExptoString().The regression covers getter order, changing flags, custom matcher receivers, pattern conversion and exceptions. Three groups fail on the original engine; all four pass after the fix.
Validation against the exact base and submitted revisions:
Known baseline failure: the full sanitizer local suite has the same
test_std.jssecond-pipe-handler assertion on both revisions, on Linux and macOS. Its runner exits zero despite that assertion; the counts and diagnostics were checked directly. The new regression passes under sanitizers. Full Windows test262 and full Linux sanitizer test262 were not run.Implemented and tested with Codex assistance.