Repository navigation
Track remaining PORT-010 exclusions upstream - #2298
Merged
Merged
Conversation
Owner
Author
QA PASS: atm-bg-6.sc081-4-r2-fix round 2Generated: 2026-10-29T22:07:48Z Machine Status (JSON){
"task": "atm-bg-6.sc081-4-r2-qa",
"checked_bead": "atm-bg-6.sc081-4-r2-fix",
"sprint": "bg-6",
"round": 2,
"branch": "fix/bg-6-sc081-4",
"commit": "05b6e12151fb5ab773883a55bed0f4af7edaddb1",
"verdict": "PASS",
"deliverables": {"complete": 1, "total": 1 },
"findings": {"blocking": 0, "important": 0, "minor": 0, "ceremony": 0 }
}FindingsNo new findings; locked SC081-4 verification passed. Carried Findings
Reviewers
Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sc-lint 0.8.2 still reports PORT-010 for all 18 paths when each exclusion is removed independently. Keep the exclusions while the upstream team classifies the cases, tracked in sc-lint #786; #720 covers the crate-root case only. Remove each exclusion when a released sc-lint fix covers its findings and the unsuppressed check passes.
Before and after the reason change, the published sc-portability check returned
version 0.8.2,status pass,findings []. With each path individually unsuppressed at d70ff22, the exact emitted findings are captured in #786; counts:crates/atm-core/src/atm_temp.rs: 4 PORT-010 finding(s)crates/atm-core/src/atm_temp_sweeper.rs: 2 PORT-010 finding(s)crates/atm-core/src/descriptor_limit.rs: 1 PORT-010 finding(s)crates/atm-core/src/persistence.rs: 1 PORT-010 finding(s)crates/atm-core/src/transfer_script.rs: 2 PORT-010 finding(s)crates/atm-daemon-bootstrap/src/lib.rs: 2 PORT-010 finding(s)crates/atm-daemon-bootstrap/src/protected_trust_root.rs: 2 PORT-010 finding(s)crates/atm-daemon-client/src/lib.rs: 2 PORT-010 finding(s)crates/atm-herdr/src/transport_socket.rs: 1 PORT-010 finding(s)crates/atm-http-runtime/src/client.rs: 1 PORT-010 finding(s)crates/atm-http-runtime/src/client_tail.rs: 3 PORT-010 finding(s)crates/atm-http-runtime/src/http1_server.rs: 1 PORT-010 finding(s)crates/atm-http-runtime/src/lib.rs: 3 PORT-010 finding(s)crates/atm-http-runtime/src/loopback_tcp.rs: 2 PORT-010 finding(s)crates/atm-http-runtime/src/runtime_listener.rs: 1 PORT-010 finding(s)crates/atm-http-runtime/src/runtime_setup.rs: 1 PORT-010 finding(s)crates/atm-http-runtime/src/unix_socket.rs: 17 PORT-010 finding(s)crates/atm/src/main.rs: 1 PORT-010 finding(s)Deliverables
Bead:
atm-bg-6.sc081-4-r2-fixGenerated by arch-ctm@atm-dev codex:terra