Repository navigation
Drop 3 low-value Issues regression tests - #8556
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed all ~60
tests/Issues/dirs. The set is tight - each dir guards a distinct rule interaction, parser edge, infinite-loop, printer-crash, scope or config-API case, with no true duplicates. Only 3 earn removal:RenameString- the two registered rules do not actually interact; the fixture shows onlyRenameStringRectoracting, so the pairing is contrived.EmptyLongArraySyntax-SensitiveConstantNameRectoris unrelated noise; the real check (param default copied from parent prints right) is narrow.GetValueMagicDir- custom test-rule for__DIR__value resolution, an engine feature already covered by core unit tests.Everything else - including sibling-package rules (TestWith/TestDoc/Downgrade) whose only local coverage is their Issues dir - is kept.