Fix PhpAstExtractor import removal in composer-based Symfony set - #1070
Merged
TomasVotruba merged 4 commits intoSep 23, 2026
Merged
TomasVotruba merged 4 commits into
TomasVotruba merged 4 commits into
Conversation
Member
|
Can you add validation to the rename itself to throw an exception if class name is the same? |
Member
|
Also, it seems it should be corrected, not removed:
|
Contributor
Author
|
Thanks, fixed it. Now it should replace |
Member
|
No need for test, this is a core rule. |
Contributor
Author
|
Removed the test |
Member
|
Thank you 👍 |
TomasVotruba
enabled auto-merge (squash)
September 23, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer based Symfony set included a rename rule that mapped
Symfony\Component\Translation\Extractor\PhpAstExtractorto itself. When Rector processed code using that class, it could remove the use import even though the class was still referenced