Repository navigation
Fix: Stop shipping dashboard/test-results to npm and user projects - #47
Open
VitorCoelho wants to merge 5 commits into
Open
VitorCoelho wants to merge 5 commits into
VitorCoelho wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.gitignoreand.npmignore:dashboards/test-results/→dashboard/test-results/(the folder isdashboard, singular).test-resultstoDASHBOARD_EXCLUDESinsrc/init.js, soinit/updatenever copy it into the user's project.dashboard/test-results/.last-run.json.dashboard/test-resultsis not copied.Why
Because of the typo,
dashboard/test-results/.last-run.json(a local Playwright artifact) was being published to npm and copied into every project that runsnpx opensquad init/update. The installer log even showsUpdated dashboard/test-results/.last-run.json.How to test
npm test→ 126 passing (the updated init test fails without the fix insrc/init.js).npm pack --dry-run→ notest-resultsfiles listed anymore.Checklist
node --testpasses