Skip to content

Fix: Stop shipping dashboard/test-results to npm and user projects - #47

Open
VitorCoelho wants to merge 5 commits into
renatoasse:masterfrom
VitorCoelho:fix/exclude-dashboard-test-results
Open

VitorCoelho wants to merge 5 commits into
renatoasse:masterfrom
VitorCoelho:fix/exclude-dashboard-test-results

Conversation

@VitorCoelho

@VitorCoelho VitorCoelho commented Oct 18, 2026 •

Copy link
Copy Markdown

What

  • Fix a typo in .gitignore and .npmignore: dashboards/test-results/ → dashboard/test-results/ (the folder is dashboard, singular).
  • Add test-results to DASHBOARD_EXCLUDES in src/init.js, so init/update never copy it into the user's project.
  • Remove the committed dashboard/test-results/.last-run.json.
  • Extend the existing init test to assert that dashboard/test-results is not copied.

Why

Because of the typo, dashboard/test-results/.last-run.json (a local Playwright artifact) was being published to npm and copied into every project that runs npx opensquad init / update. The installer log even shows Updated dashboard/test-results/.last-run.json.

How to test

  • npm test → 126 passing (the updated init test fails without the fix in src/init.js).
  • npm pack --dry-run → no test-results files listed anymore.

Checklist

  • node --test passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant