Repository navigation
Fix MVN noise handling and train-only CompositePCA scaling - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BEL.predict(noise=...)values before the MVNcovariance path consumes them. Preserve the historical
Nonereset to0.01.during transform and undo them before inverse projection.
components, including
Noneand variance-fraction configurations.The noise parameter retains its existing projected-covariance convention; this
does not reinterpret it as physical-space observation standard deviation.
Verification
Eight new small regression tests capture actual MVN covariance inputs, rejected
noise values, held-out batch invariance, frozen training scalers, roundtrips,
component settings and shape/fittedness errors. The full local upstream suite
and Ruff checks pass; the repository's CI matrix provides additional Python/OS
compatibility checks. No dependencies or other inference algorithms change.
This fixes software contracts. It does not establish posterior calibration or
application-specific scientific performance. Refit previously fitted scaled
CompositePCA objects to establish the new training-scaler state.