Default development server to loopback and preserve bind interface - #555
Merged
Merged
Conversation
Code CoverageCoverage report could not be generated. Show output |
Pedantic ClippyNo pedantic warnings found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The development server previously defaulted to all interfaces, and a failed explicit loopback bind could fall back to all interfaces. Default
--serveto127.0.0.1:8000and preserve the requested IPv4/IPv6 interfaces when retrying on an OS-assigned port. Explicit network binds remain supported.Label the server as development-only in CLI help, source comments, terminal startup output, and documentation. Add binding regression tests and a draft release note.
This intentionally addresses only binding defaults/fallback and development-only messaging. Editor/API behavior is unchanged; no authentication, CSRF/CORS checks, or filesystem restrictions are introduced. This does not resolve the broader path-traversal findings.
Related to #554.
Validation: formatting, Clippy with warnings denied, the full unit/integration test suite, and
mask pedanticpassed with Rust 1.96. The example site also builds successfully.Browser visual verification could not run because the browser tool rejected this session's API-key authentication. The preview server started successfully on loopback and printed the development-only message.