Repository navigation
Improve warning line/column accuracy and error messages - #30
rockneurotiko wants to merge 1 commit into
Conversation
Fixed:
- Warning line and column numbers are now accurate for all macro
variants (~GQL sigil, gql heredoc, gql inline string, gql_from_file).
Previously, line numbers were off by one due to a spurious +1 in
the offset calculation.
- Single-line gql("...") string arguments now correctly map errors
to the call site line.
- gql_from_file errors now report lines relative to the external file
rather than the call site.
- Runtime validation no longer double-formats error messages.
Improved:
- Validation errors originating in external fragments (via fragments:
option) now include context with the fragment name and line, and
point to the ...FragmentName spread in the query rather than the
sigil line.
- 'expected value of type X, found a variable' messages are now
enriched with the variable name and declared type, e.g.
'found variable `$traveller_guid` of type `String!`'
- Added THIRD_PARTY_LICENSES.md for apollo-compiler (MIT/Apache-2.0).
Added 18 new tests covering all of the above.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdates Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Documentation
Chores