Repository navigation
fix: escape full @deprecated reason correctly - #32
Conversation
render_deprecated/1 only escaped `\` and `"` before now it escapes all characters from the graphql spec for StringValue
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request refactors deprecation string escaping in SDL generation by extracting inline escaping logic into dedicated ChangesDeprecation String Escaping Refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rockneurotiko
left a comment
There was a problem hiding this comment.
Much better! Thanks for the PR!
Let me review it and test it locally 😄
|
Thanks for the contribution! 🧡 |
Currently if you use the remote schema with a schema that has newlines in the deprecated reason string it crashes. The cause is the render_deprecated/1 function which only escaped
\and"before now it escapes all characters from the graphql spec for StringValue specifically added support for characters\b,\r,\n,\f,\talong with a range of unicode characters from the spec.If you have feedback eg. want to add a fixture to tests etc or think it's overkill supporting all of them I can change it.
PS, thanks for adding support for downloading remote schemas I was using a mix task calling a js package to do this before and I saw you updated the README saying this library is used in prod
Summary by CodeRabbit
Bug Fixes
Tests