You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Small correctness and cleanup follow-ups from the #277-#279 round #285
Found by independent verifiers and owners during #280, #281 and #282. All items exist on dev at 4cde607; none was introduced by those PRs.
Correctness:
ElectronicBandStructure.build_overlay_orbitals_weights raises AttributeError: 'list' object has no attribute 'get' at core/ebs.py:1467 and :1527.
The VASP parser passes the 16-name orbital table (io/vasp/parser.py:345) for 9-orbital PROCARs to both the EBS and the DOS; any code pairing names with the orbital axis can mis-index (the Unfolder no longer does, since fix(unfold): make pyprocar.unfold draw correct unfolded bands #282).
io/abinit/output.py:74,82 uses 27.211396641308 instead of HARTREE_TO_EV 27.211386245988 (bands Fermi off by ~1e-4 eV).
A spin-polarized dosplot labels both channels "Total - ↑".
autobandsplot writes report.txt into the current working directory.
Elk 10.7.8 and later use the irreducible-representation basis for task 22 by default (lmirep=.true.), so the Ylm orbital names are wrong for those runs.
Graphene BS2D surfaces (data/examples/bands/2d-bands/graphene) render jagged and spiky; not investigated.
Cleanup:
scripts/procar.py subcommands fermi2D, filter and cat look stale against the current API (unchecked).
UnfoldPlotMode.SACATTER and the matching member in scriptBandsplot are misspelled.
docs/source/api/cfg/index.rst lists yml files that do not exist; api/cfg/unfold.rst shows stale values (e.g. color: black instead of #eeeeee).
Saved notebook outputs are stale: the unfolding notebook, and examples/00-band_structure/00-Getting Started.ipynb:590-591 (lists the removed weighted_color/weighted_width).
The VASP parser now passes one orbital name per projected orbital, and the ElectronicBandStructure and DensityOfStates constructors raise on any mismatch (check_projected_layout).
io/abinit/output.py now uses HARTREE_TO_EV and AU_TO_ANG from pyprocar/utils/units.py; tests/test_unit_constants.py fails on any hand-typed copy.
Fixed in dev by #304. All remaining items are done, as are the overlay-weight AttributeError and the Elk lmirep naming released after #298. The verdicts are on #304. The CHANGELOG has an Unreleased section noting autobandsplot report= and the SCATTER rename (SACATTER is kept as a deprecated alias).
Activity
lllangWV commentedon Oct 4, 2026
Two more pre-existing items found during #281 round 9 (both reproduce on
dev4cde607):FermiSurface.load(path)withoutebsleavesoriginal_ebsas None; the slicer callback then crashes in_active_scalars_info, so no area text appears.FermiSurface.from_ebsinstead of raising a clear error.Enforce the recurring agent mistakes as checks and fix what they found (
lllangWV commentedon Oct 4, 2026
Two items are fixed in dev by #291 (d6d4aaa):
The other items stay open.
docs(verify-pyprocar): record the #285 fixes in the feature map
docs(verify-pyprocar): record the #285 fixes in the feature map
chore(basedpyright): drop baseline entries the #285 rewrites removed
style: wrap the #285 lines that ruff flags as too long or unformatted
refactor: tighten the #285 round-2 grid and version code and format t…
assets: #285 round 2 Cartesian BS2D before/after
fix: resolve the #285 follow-ups (DOS labels, autobandsplot report, B…
lllangWV commentedon Oct 4, 2026
Fixed in dev by #304. All remaining items are done, as are the overlay-weight AttributeError and the Elk lmirep naming released after #298. The verdicts are on #304. The CHANGELOG has an Unreleased section noting autobandsplot report= and the SCATTER rename (SACATTER is kept as a deprecated alias).