You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Projection layout follow-ups: non-collinear spin channels, axis order and orbital names per parser #293
The verifiers of #291 (comments 5981491331 and 5981502918) found these older gaps. #291 did not cause them, but its new check_projected_layout cannot catch them yet.
QE non-collinear band structures have 1 spin channel. The projections come out as (k, band, 1, 5, 32) instead of 4 spin channels (total, Sx, Sy, Sz). Abinit non-collinear DOS also has 1 spin channel. The check counts axes only, so both pass.
The check cannot see swapped axes. A 5-D array with the spin and atom axes swapped passes. A stronger check would compare shape[:2] with the bands array, the atom axis with structure.natoms when a structure is given, and the spin axis with 1, 2 or 4 consistently with the band count.
Orbital names are never compared where a parser passes none. That covers QE band structures and the Abinit, QE, Elk and Lobster DOS. Each parser should pass the names of the orbitals it actually projects.
VASP names its orbitals by cutting a fixed list, not by reading the PROCAR header. A filtered PROCAR whose header reads o0 (the bands/auto fixture) is labelled ['s'].
Related: #220 and #219 (QE non-collinear parsing).
Activity
test(core): projections whose axes disagree with bands, total or stru…
fix(core): check projection axes against the bands, total DOS and str…
test(qe): non-collinear band structures carry total, Sx, Sy and Sz pe…
fix(qe): give non-collinear band structures total, Sx, Sy and Sz per …
test(io): every parser names the orbitals it projects
fix(io): pass the orbital names each parser projects
test: type the layout and QE spinor test inputs for basedpyright
refactor(qe): parse projwfc states into a SpinorState before the spin…
docs(claude): state what check_projected_layout now enforces
test(core): projections whose axes disagree with bands, total or stru…
fix(core): check projection axes against the bands, total DOS and str…
test(qe): non-collinear band structures carry total, Sx, Sy and Sz pe…
fix(qe): give non-collinear band structures total, Sx, Sy and Sz per …
test(io): every parser names the orbitals it projects
111 remaining items
fix(ebs): drop projected_phase when padding a mesh
test(qe): unfolded QE bands are eigenvectors of their little group
docs(verify-pyprocar): state the band windows and image energies of t…
test: reuse the sphere mesh helpers and index each little group once
test(qe): narrow the optional mesh fields for basedpyright
test(qe): QE phases unfold to the coefficients at each grid point
fix(qe): unfold QE phases and f orbitals with the core's harmonics
fix(qe): keep the Bloch factor when the parser has no projwfc.x orbitals
test(fermi): the Fermi-surface mesh pads projections but not phases
fix(ebs): drop projected_phase when padding a mesh
test(qe): unfolded QE bands are eigenvectors of their little group
docs(verify-pyprocar): state the band windows and image energies of t…
test: reuse the sphere mesh helpers and index each little group once
test(qe): narrow the optional mesh fields for basedpyright
fix(qe): unfold QE phases and f orbitals with the core's harmonics (#305