Skip to content

Plotting and script defects found during the #284-#305 round #306

Closed

Description

@lllangWV

Found by owners and verifiers during #294, #298 and #304. All of these exist on dev at 499b1bc. None was introduced by those PRs.

  • fill_between_image (pyprocar/plotter/dos_plot.py ~571-589) mixes the baseline into the energy-axis image extent and into the clip polygon. Parametric DOS colours land at the wrong energies when the window does not contain 0. In vertical mode (bandsdosplot) the polygon is wrong.
  • bandsplot(print_plot_opts=True) prints nothing: the user logger defaults to ERROR, and quiet_welcome also sets ERROR.
  • autobandsplot spin-down branches read spin up: write_report takes states_down = self.defect_states[i][0], and simple_energy_window uses bands_up for b_down.
  • VASP autobandsplot() without fermi uses 0.
  • bandsdosplot draws its Fermi line at y=0 when the energies are not shifted.
  • BandStructurePlotter.plot_overlay (bs_plot.py:986) crashes when given ebs.bands, a Property; examples/general/new_bands_examples.py passes exactly that. plot(vectors_mode=...) also crashes.
  • bandsplot(atoms=[]) and unfold(atoms=[]) raise IndexError from atoms[0] (scriptBandsplot.py:230, scriptUnfold.py:185) instead of the core's clear "names no atoms" error.
  • orbitals=[] still selects every orbital, while empty atoms and spins now raise.
  • FermiSlicePlotter._to_series lets the surface's active scalars/vectors override the scalars_name/vectors_name the user passed, so the name is ignored and the "not found" warning never fires.
  • FermiSlicePlotter.plot(scalars_data=<Property>) draws uncoloured lines: it looks the Property up by name in point data that get_property never sets (fs_slice_plot.py:184).
  • procar.py generate2dkmesh raises TypeError.
  • Three copies of the BandStructureMode enum (cfg/band_structure.py, cfg/unfold.py, scriptBandsplot.py) have diverged and should become one.
  • scripts/scriptVector.py:38 prints "WARNING: ..." (the module looks dead: not exported or imported).

Activity

  1. lllangWV commented on Oct 6, 2026

    @lllangWV
    MemberAuthor

    Superseded by #308, #312, #313 (items moved per triage)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions