Repository navigation
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Found by owners and verifiers during #293, #299, #304 and #305. All of these exist on dev at 499b1bc. None was introduced by those PRs.
Spin and orbital layout:
- QE non-collinear DOS still has 1 j-resolved spin channel (7435, 1, 5, 32). The non-collinear contract is 4 channels.
-
DensityOfStates.is_non_collineartreats any 32-orbital DOS as non-collinear, so the QE spin-orbit DOS (1 channel) reports non-collinear with spin names it cannot index. QE non-collinear DOS without spin-orbit is probably read as collinear:ProjwfcDOS.is_non_colinearchecks onlyj. (Inferred, not run.) - Core
AZIMUTHAL_ORBITAL_ORDERspellsdzx/dzyand wrong f names, and the index groupst2g(4, 5, 7) andeg(5, 6, 8) assume VASP column order, which mislabels QE and Elk selections. Reorder columns into one core order at the parser boundary. - VASP DOS orbital names still come from a fixed list, while VASP bands read the PROCAR header.
- Elk task-10 DOS columns are in the irrep basis when
lmirepis on, but keepY{l}{m}names (fix: resolve the #285 follow-ups (DOS labels, autobandsplot report, BS2D grid, overlay weights, Elk lmirep) #304 named the task-22 band characters only). - Lobster DOS is probably all zeros on real files:
DoscarLobster.projected_dosmatches labels likesexactly, while real headers likely carry principal numbers (4s 3d_xy). (Inferred, not run.)
Phases and unfolding:
-
QEParser.spd_phase(parser.py ~688) adds the complex amplitudes of radial channels that share (l, m) on one atom (semicore Sr 4s+5s, La 5p+6p), sospd = |sum c|^2includes cross terms. Against projwfc.x's own weights: Sr s off by up to 0.48, Sr p by 0.36, V s by 0.24. -
ebs.unfoldcrashes on a spin-polarized QE path (norm[:, :, None]at pyprocar/utils/unfolder.py:61). Translations that match no atom fall back to basis 0, so a structure that is not a supercell silently gets wrong weights. - Abinit PROCAR phases are passed to the core without a check of Abinit's real-harmonic sign convention against the core's (fix(qe): unfold QE phases and f orbitals with the core's harmonics #305 did this for QE). No Abinit fixture has phases.
-
pyprocar.filter(atoms=...)fails on a PROCAR with phase blocks (inhomogeneous shape), and an orbital-filtered phase PROCAR fails to reshape in unfold, so no filtered file can reach unfold. - VASP spin-polarized phase parsing concatenates along the band axis, giving shape (k, 2b, 2, ...).
-
expand_kpoints_to_supercell_by_axescopies phases to k+G without exp(-2 pi i G.tau), andElectronicBandStructureMesh.interpolateFFT-interpolatesprojected_phase, which is gauge-dependent and not periodic. Neither has an in-repo caller.
Meshes and surfaces:
-
Mesh.is_fbz,is_ibzandkgridstill infer the grid from histogram peaks (math.get_grid_dims). - QE
ebs.fermicomes from the scf, not the nscf XML (12.549 against 12.465 eV on SrVO3). -
clip_surfaceaborts the whole Fermi surface when a single band clips to empty. A[0,1)grid on a hexagonal lattice with NK > 30 misses part of the Wigner-Seitz cell. - The shared
data/codes/qe/...fixtures contain oldebs.pklcaches from before fix(ebs): make ibz2fbz unfold magnetic groups, phases, atoms and orbitals correctly #299/fix(qe): unfold QE phases and f orbitals with the core's harmonics #305. Withuse_cache=Truethey load the old projections and phases.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Activity
lllangWV commentedon Oct 6, 2026
Superseded by #302, #312, #313 (items moved per triage)