Skip to content

Break the import cycles through pyprocar/core/__init__.py that destabilize the basedpyright baseline #320

Open

Description

@lllangWV

Two builders in the #302 round (#317) hit basedpyright lock-mode failures from reportImportCycles entries on pyprocar/core/__init__.py, a file they had not touched. One spent about 8 minutes reading basedpyright's source to work out why.

basedpyright reports only a capped number of cycles per file. So any new import inside pyprocar.core reshuffles which cycles get reported, a baseline entry disappears or a new one appears, and lock mode fails on code nobody changed. The workaround is to import the submodule directly (import pyprocar.core.kpoints as kpoints) or keep the import type-only, but every agent has to rediscover it.

  • Remove the import cycles through pyprocar/core/__init__.py (have submodules import each other directly, not through the package).
  • Delete the reportImportCycles baseline entries the change makes obsolete, in their own commit.

Activity

  1. added
    agent-queueAgent follow-up; worked through by a backlog sweep
    on Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-queueAgent follow-up; worked through by a backlog sweep

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions