Skip to content

fix: standby audit batch 1 (colour validation, per-instance CSS, docs, README) - #10

Merged
aravindhebbali merged 2 commits into
masterfrom
fix/audit-batch1
Oct 25, 2026
Merged

aravindhebbali merged 2 commits into
masterfrom
fix/audit-batch1

Conversation

@aravindhebbali

Copy link
Copy Markdown
Member

Audit batch 1 for a 0.2.1 patch release: colour arguments can no longer inject HTML, loaders of the same type keep their own colours, alertify docs match the code, and the README example works again. This repo has no develop branch, so the PR targets master (as yahoofinancer did).

Changes

  • Colour validation: a new internal validate_color() is used by threeDots(), spinkit(), spinners() and vizLoad(). It accepts colour names, hex, rgb()/rgba()/hsl()/hsla() with numbers (including .5 alphas), transparent and currentColor; anything else errors with a clear message. Before, a value such as red</style><script>…</script><style> broke out of the <style> block. vizLoad(type) is checked with match.arg().
  • Per-instance CSS: loader colour rules (and the type-5 spinner keyframes) are scoped to each widget's id, so two loaders of the same type no longer take the last one's colour.
  • alertify docs now state the real defaults (maximizable, modal, movable, overflow, auto_reset, move_bounded, pinnable); behaviour unchanged.
  • README: the alert example is correct and runs.
  • Stray console.log removed from the tooltip script. NEWS updated.

Evidence

  • Agents: Gemini built batch 1. DeepSeek review GS1R: CHANGES REQUESTED (leading-dot alpha rejected, type-5 keyframes still global, pinnable doc). Fix round 9a6c022; re-review GS1RR: SIGN-OFF, with R CMD check --as-cran 0 errors, 0 warnings, 1 NOTE (also on base).
  • Claude's checks: the injection payload is rejected by all four loaders, and a valid hex colour still renders. Two spinners(type = 1) give #spinner-1 … and #spinner-2 … rules with their own colours. No console.log left.

Follow-ups (later batches)

Remaining audit items N4–N10 and roadmap C1–C17 (e.g. module-safe ids, toast()/notify() docs, the resizeable typo).

🤖 Generated with Claude Code

https://claude.ai/code/session_017Pjp8KpLFzJUxMnsCgkoUN

@netlify

netlify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for visionary-chebakia-58f9ad ready!

Name Link
🔨 Latest commit 9a6c022
🔍 Latest deploy log https://app.netlify.com/projects/visionary-chebakia-58f9ad/deploys/6ade3c337d3a9c4a224456b1
😎 Deploy Preview https://deploy-preview-10--visionary-chebakia-58f9ad.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aravindhebbali
aravindhebbali merged commit 9897c13 into master Oct 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant