Repository navigation
fix: standby audit batch 1 (colour validation, per-instance CSS, docs, README) - #10
Merged
Merged
Conversation
…ADME example (standby batch 1)
✅ Deploy Preview for visionary-chebakia-58f9ad ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit batch 1 for a 0.2.1 patch release: colour arguments can no longer inject HTML, loaders of the same type keep their own colours,
alertifydocs match the code, and the README example works again. This repo has nodevelopbranch, so the PR targetsmaster(as yahoofinancer did).Changes
validate_color()is used bythreeDots(),spinkit(),spinners()andvizLoad(). It accepts colour names, hex,rgb()/rgba()/hsl()/hsla()with numbers (including.5alphas),transparentandcurrentColor; anything else errors with a clear message. Before, a value such asred</style><script>…</script><style>broke out of the<style>block.vizLoad(type)is checked withmatch.arg().alertifydocs now state the real defaults (maximizable,modal,movable,overflow,auto_reset,move_bounded,pinnable); behaviour unchanged.console.logremoved from the tooltip script. NEWS updated.Evidence
pinnabledoc). Fix round9a6c022; re-review GS1RR: SIGN-OFF, withR CMD check --as-cran0 errors, 0 warnings, 1 NOTE (also on base).spinners(type = 1)give#spinner-1 …and#spinner-2 …rules with their own colours. Noconsole.logleft.Follow-ups (later batches)
Remaining audit items N4–N10 and roadmap C1–C17 (e.g. module-safe ids,
toast()/notify()docs, theresizeabletypo).🤖 Generated with Claude Code
https://claude.ai/code/session_017Pjp8KpLFzJUxMnsCgkoUN