Repository navigation
Keep Tunnel as an installable example operator - #368
Open
jeffcrouse wants to merge 2 commits into
Open
jeffcrouse wants to merge 2 commits into
jeffcrouse wants to merge 2 commits into
Conversation
Rescued from the local-only feat-grid-reactive-visuals branch, where it existed in exactly one commit reachable from one un-pushed branch — a `git branch -D` from being gone. Nothing referenced it: not that branch's grid.py, not even its own project.json. It was written and then orphaned when the demo moved to InstanceGrid. It is worth keeping. Verified against ABI 17 on current main: compiles, registers, spawns, and renders a real frame (1280x720, is_blank false, 33% non-black) — a monochrome corridor of concentric rings and radial spokes receding to a vanishing point, which is exactly what the source claims. Home is `packages/example-visuals`, alongside Gradient: source-only, installed on demand via install_operator_package, no CMake target and no core registration. That respects ADR-0054's lean core — a single-look operator does not belong in the spine — while making the thing discoverable instead of dying on a branch. It needs only the three operator_api headers Gradient needs, so there is nothing to vendor. NOT placed in examples/operators/Tunnel/: that tree is GENERATED from app/operators/packages by tools/operator_audit/gen_examples.py, so a hand-added folder would be an orphan the generator does not know about. Gradient likewise has no folder there, for the same reason — an installable example is not a registered op. The branch has also been pushed to origin/feat-grid-reactive-visuals so nothing else on it depends on one laptop. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8hiFecYKwDbXW857wAzBU
Contributor
Production gate (core): ✅ PASS
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rescued from the local-only
feat-grid-reactive-visualsbranch, wheretunnel.cppexisted in exactly one commit reachable from one un-pushed branch — onegit branch -Dfrom gone. Nothing referenced it: not that branch'sgrid.py, not even its ownproject.json. Written, then orphaned when the demo moved toInstanceGrid.It's worth keeping
Verified against ABI 17 on current main:
is_blank: false, 33% non-blackThe frame is a monochrome corridor — concentric rings and radial spokes receding to a vanishing point — exactly what the source claims.
Why
example-visualsAlongside
Gradient: source-only, installed on demand viainstall_operator_package, no CMake target, no core registration. That respects ADR-0054's lean core — a single-look operator doesn't belong in the spine — while making it discoverable instead of dying on a branch. It needs only the threeoperator_apiheaders Gradient needs, so there's nothing to vendor.Not placed in
examples/operators/Tunnel/: that tree is generated fromapp/operators/packagesbygen_examples.py, so a hand-added folder would be an orphan the generator doesn't know about. Gradient has no folder there either, for the same reason.Two things this surfaced
A scare that turned out to be mine, not main's. Installing the package first failed with
Gradientunable to findconcise_gpu_error/report_if_no_pipeline— helpers #337 added an hour earlier. It was my local build being stale:src/operator_api/gpu_common.hhad them, the bundledResources/operator_api/gpu_common.hdidn't. A rebuild fixed it; main is fine.But the near-miss is worth noting. Installable packages compile against the bundled headers, and no test exercises that path. The vendored-snapshot guard catches source copies drifting; nothing catches shipped headers drifting from shipped example sources. A real mismatch would reach users as a compile error the first time they try to author an operator — which is the product's north star. Worth a guard that installs a package in CI.
feat-grid-reactive-visualshas also been pushed to origin so nothing else on it depends on one laptop.🤖 Generated with Claude Code
https://claude.ai/code/session_01X8hiFecYKwDbXW857wAzBU