Document macOS agent installation - #24
Conversation
|
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
This comment has been minimized.
This comment has been minimized.
6513c89 to
099590e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b3e4857 to
ee391de
Compare
This comment has been minimized.
This comment has been minimized.
ee391de to
15c3c6c
Compare
This comment has been minimized.
This comment has been minimized.
15c3c6c to
3edf477
Compare
This comment has been minimized.
This comment has been minimized.
actions/checkout@v7 is valid. Other pages using v4 does not make the new example incorrect. |
|
The base image page predates two changes that landed on 1.
|
Add installation and base-image preparation workflows for Apple Silicon agents, including enrollment, service management, verification, and updates. Signed-off-by: Han Verstraete <han@openfaas.com>
Signed-off-by: Han Verstraete <han@openfaas.com>
3edf477 to
4550ca4
Compare
This comment has been minimized.
This comment has been minimized.
|
The sync looks good — CLT is called out in the intro, the Xcode section covers 1. How Xcode is writtenChecked against Apple's own artefacts rather than memory, since it came up:
So it is Xcode — capital X, lowercase c. This PR is already correct throughout: prose uses 2. Heading rename
3. Intro wordingThe suggested rewrite is a better opening — it explains why there is no image to download, which the current text leaves implicit. One factual tightening: it reads as though two stages install the CLT, and it drops the runner. The stages are actually:
So "two additional stages" is right, but the CLT and the runner arrive together in the first of them. Worth keeping "Actuated does not distribute macOS due to restrictions in the EULA limiting redistribution" — that is a stronger reason than the current phrasing gives. 4. The verify block — I think you are half right to cut itYour instinct to drop it is correct for the plain base. It duplicates the test build, and a base that cannot boot will fail loudly at the first job anyway, so four commands buys very little. It is not redundant for the Xcode tier, though. The test build is a generic specs job — it never invokes The honest reason the block looks so complicated is that the CLI has no composite verb, so the docs have to spell out clone → run → health → rm by hand. Rather than documenting four commands or dropping the check entirely, I would rather fix that end: a single Suggestion: cut the block now as you proposed, and leave the Xcode section saying the first iOS build is the real test. I will follow up with the single command and then this page gets one line back instead of four. |
Explain how to create an Xcode-enabled base image, select platform support and Xcode versions, and configure the agent service to use it. Signed-off-by: Han Verstraete <han@openfaas.com>
4550ca4 to
598c841
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Han Verstraete <han@openfaas.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Explain the FileVault requirements for unattended recovery and provide a complete, manually triggered test workflow. Signed-off-by: Han Verstraete <han@openfaas.com>
dee5895 to
1d0d6a5
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Han Verstraete <han@openfaas.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)7/10. The documentation is useful and structured, but onboarding can still block readers who lack arkade or need to verify an Xcode image. Summary per fileSummary per file
Overall AssessmentThis is a solid documentation addition for a new macOS agent workflow. The pages are scoped well, the navigation placement makes sense, and the split between agent installation and base-image preparation keeps the flow manageable. The main merge risk is not rendering safety; it is reproducibility for first-time readers following the commands exactly. The guide should close two gaps before publication: it should show how to install Detailed ReviewDetailed ReviewContent reviewNo blocking findings. Medium: The macOS install guide depends on
|
Description
Add installation and enrollment instructions for the native macOS agent.
Document automatic and manual base-image preparation.
Motivation and Context
Provide a complete onboarding path for running the Actuated agent on Apple
Silicon.
How Has This Been Tested?
workflow.
Types of changes
Checklist:
git commit -s