Skip to content

Perform MSRV checks against a minimal lockfile - #1255

Merged
kayabaNerve merged 21 commits into
nextfrom
minimal-msrv
Aug 30, 2026
Merged

kayabaNerve merged 21 commits into
nextfrom
minimal-msrv

Conversation

@kayabaNerve

Copy link
Copy Markdown
Member

Fixes #1246.

@kayabaNerve kayabaNerve added the improvement This could be better label Jul 25, 2026
@kayabaNerve
kayabaNerve force-pushed the minimal-msrv branch 29 times, most recently from acf7727 to 65ae6a4 Compare July 26, 2026 19:57
This is only when using our patch. The MSRV lint manually runs
`cargo update -p expander` to handle its edge case with minimal versions.
@kayabaNerve
kayabaNerve force-pushed the minimal-msrv branch 2 times, most recently from 2d5eadf to 0b5283f Compare August 18, 2026 13:08
This uses the versions published to crates.io and removes the `simple-request`
patch 🎉

For the FCMP++ libraries we use, this updates to the version with their MSRVs
corrected (as this branch does) and with the `generalized-bulletproofs` audit
by zkSecurity incorporated.
…cies

This also addes `default = ["std"]` features to `serai-client-bitcoin` and
`serai-client-ethereum`.
@kayabaNerve
kayabaNerve force-pushed the minimal-msrv branch 5 times, most recently from 26d25f5 to 53b87a4 Compare August 20, 2026 04:02
`serde_with` is a bucket crate for a variety of different encoders, decoders,
which really messes with our scoping and supply chain security efforts. This
implements the necessary functionality within Serai proper, allowing removing
three other patches.
@kayabaNerve
kayabaNerve force-pushed the minimal-msrv branch 2 times, most recently from 63215c6 to 9cc19ab Compare August 29, 2026 13:36
@kayabaNerve
kayabaNerve force-pushed the minimal-msrv branch 6 times, most recently from 4e4da2d to 3bcd172 Compare August 29, 2026 23:32
This wasn't prior possible because having _any_ crate in the workspace with
`edition = "2024"` forced the MSRV of _every_ crate to `1.85`. The new MSRV
workflow checks each crate in its own workspace however, making this
irrelevant.
This broke overnight due to a Docker update which changed the default
configuration.

`pasta`, and the associated port driver `implicit`, does not work. The
`builtin` port driver _may_ work with `pasta`? But this explicitly installs
`slirp4netns` to revert back to the old pairing, which was known to work.
@kayabaNerve
kayabaNerve merged commit bc1bf4f into next Aug 30, 2026
51 of 57 checks passed
@kayabaNerve
kayabaNerve deleted the minimal-msrv branch August 30, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement This could be better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant