Repository navigation
build(deps): bump pyramids-core floor to >=0.71.0 - #128
Merged
Merged
Conversation
CdseS3Signer.gdal_env() relies on pyramids-core routing a custom S3 endpoint to GDAL's multi-threaded read workers, which shipped in pyramids-core 0.71.0 (serapeum-org/pyramids-core#1348). On the previous 0.70.0 floor a multi-threaded CDSE read (merge_rasters / stack_bands / any gdal.Warp fan-out) sends worker requests to real AWS and 403s, so the signer was not correct for the lowest version it declared. Raise the floor in the base dependency and the viz extra and re-lock; no signer code change is needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 2948 2948
Branches 445 445
=========================================
Hits 2948 2948 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…to build/bump-pyramids-core-0.71 # Conflicts: # pixi.lock # pyproject.toml
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Raise the
pyramids-coredependency floor from>=0.70.0to>=0.71.0(base dependency +vizextra) andre-lock. No source change.
pyramids_eo.stac.signers.CdseS3Signer.gdal_env()returns the CDSE S3 config without aGDAL_NUM_THREADSstopgap, so a multi-threaded read of a CDSE (
eodata.dataspace.copernicus.eu) asset —merge_rasters,stack_bands, anygdal.Warp-backed fan-out — depends on the custom S3 endpoint being routed to GDAL'smulti-threaded read workers. That routing shipped in pyramids-core 0.71.0 (serapeum-org/pyramids-core#1348). On
the previous
>=0.70.0floor the worker threads fell back to real AWS and 403'd, so the signer was not correctfor the lowest version it declared. This PR pins the floor to the release that provides the fix.
The import name is unchanged (
import pyramids), andCdseS3Signeralready assumes the fix, so no signer codechange is needed.
Issues
CdseS3Signerrelies on the multi-threaded endpoint routing from pyramids-core 0.71.0(fix(remote): route a custom S3 endpoint to GDAL's multi-threaded read workers pyramids-core#1348); pinning the floor there makes the signer correct on its lowest declared version.
Type of change
Check relevant points.
The change is a dependency floor bump plus lock re-solve. Non-breaking for any consumer already on
pyramids-core >= 0.71.0.
How Has This Been Tested?
pixi lockupdated every environment (default / dev / docs /py311–py314) with exactly one version change —
pyramids-core 0.70.0 -> 0.71.0. An authoritativeset-diff of
pixi.lock(removed vs added wheel artifacts) shows the only content change is the 20pyramids_corewheels (5 platforms × 4 Python versions) swapping 0.70.0 → 0.71.0; every other package(numpy, pyogrio, tornado, …) is unchanged and merely reordered.
fix(remote): route a custom S3 endpoint to GDAL's multi-threaded read workers), confirmed in its change-log and release(#1350).
CdseS3Signer.gdal_env()emits noGDAL_NUM_THREADS, so it relies on that routing.to real AWS; 0.71.0 OK, 133 MB written). Not re-run here (needs
CDSE_S3_ACCESS_KEY/CDSE_S3_SECRET_KEY).Checklist:
The version bump and change-log entry are left to the commitizen release flow; no README version reference or
docs change is affected by a dependency floor bump, and the signer carries no new code to add tests for (its
behaviour is unchanged — only the minimum version that makes it correct).