Repository navigation
fix(macos): put the app icon back on the macOS icon grid - #1078
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1076, reported by @chen9986 on macOS Sonoma 14.6.1: the Markpad icon looked larger than the apps next to it.
Mechanism
#841 replaced the icon and rendered
icon.icnsfull-bleed: the dark tile fills the whole 1024px canvas. macOS icons are drawn on a grid where the tile is 824px with a 100px margin, which is what bfe2035 had set up for the old icon. Sonoma draws an.icnsas it is, so a full-bleed tile shows about 24% wider than its neighbours. macOS 26 and later mask and inset legacy icons themselves, which is why it only shows on older systems.icon.icnsis now the same artwork scaled into the 824px tile, centred on the 1024px canvas, at every size in the set. The other PNG and ICO icons are unchanged, since Windows and Linux expect full-bleed artwork.Verification