Repository navigation
Capture html5 clips from a freshly loaded document - #218
Merged
Merged
Conversation
|
🎉 This PR is included in version 2.24.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The html5 player captured frames from the same iframe the editor seeks while you scrub. A seek can leave state behind that a freshly loaded page doesn't have. For example, once a GSAP tween has rendered and been rewound, its start values stay inline. The captured frames therefore depended on where the playhead had been, and could differ from a render that starts from a fresh page. One case we measured: an identity transform left inline changed text antialiasing on about 5% of pixels.
runCapturenow reloads the iframe'ssrcdocand waits for it to load before capturing. Cached captures skip the reload. The player is already in capturing mode with the iframe parked, so the reload isn't visible.Verify:
npm run verify:ci. The new test scrubs the iframe, starts a capture, and checks that the first seek happens only after a fresh load of the composed document.